Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Tabs-Tray doesn't show selected tab when it is displayed

VERIFIED FIXED in Firefox 13

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
Firefox 13
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
With more than 7 tabs, on Galaxy Nexus, the list doesn't scroll to show the selected tab. It stops mid-way -- like around 4 or so.
(Assignee)

Comment 1

6 years ago
Created attachment 596873 [details] [diff] [review]
Patch

I initially felt that onWindowChanged() is called before list populates that causes this issue. Somehow the "smooth scrolling" fails, even if I move to just after requestLayout() of the container.

This patch ensures that the selected tab is shown when TabsTray displayed. This also takes care of Eclair. However, we lose the "smooth scrolling" to selected tab.

I somehow feel that there is too much animation happening -- a fade-in + drop down animation for the tray along with scrolling of the list. Without the scrolling the tabs-tray has just one animation and it doesn't seem that complex. (A better way of saying I don't have a patch for it yet ;) )
Attachment #596873 - Flags: review?(mark.finkle)
Attachment #596873 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a4ddd189b112
https://hg.mozilla.org/mozilla-central/rev/a4ddd189b112
Assignee: nobody → sriram
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

Comment 4

6 years ago
Nightly 13.0a1 (2012-02-16)
Device: Samsung Nexus S - Android 2.3.6

Verified with 8-12 tabs. Selected tab was always displayed in tab menu.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.