Move nsAudioStream rate/channels/format members up to base class

RESOLVED FIXED in mozilla13

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla13
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 596889 [details] [diff] [review]
fix
Attachment #596889 - Flags: review?
Attachment #596889 - Flags: review? → review?(kinetik)
Comment on attachment 596889 [details] [diff] [review]
fix

Review of attachment 596889 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/nsAudioStream.h
@@ +129,5 @@
>    virtual PRInt32 GetMinWriteSize() = 0;
>  
> +  int GetRate() { return mRate; }
> +  int GetChannels() { return mChannels; }
> +  SampleFormat GetFormat() { return mFormat; }

Are these used in another patch?
Attachment #596889 - Flags: review?(kinetik) → review+
Yes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/135721f3720b
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f81109133b5 for a fistful of orange in content/base/test/test_bug415860.html - your guess is better than mine about which one in the push was at fault.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d19ab244ca
https://hg.mozilla.org/mozilla-central/rev/a8d19ab244ca
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.