726891 - Move nsAudioStream rate/channels/format members up to base class

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 596889 [details] [diff] [review]
fix

Review of attachment 596889 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/nsAudioStream.h
@@ +129,5 @@
>    virtual PRInt32 GetMinWriteSize() = 0;
>  
> +  int GetRate() { return mRate; }
> +  int GetChannels() { return mChannels; }
> +  SampleFormat GetFormat() { return mFormat; }

Are these used in another patch?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/135721f3720b

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f81109133b5 for a fistful of orange in content/base/test/test_bug415860.html - your guess is better than mine about which one in the push was at fault.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d19ab244ca

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/a8d19ab244ca