Last Comment Bug 726891 - Move nsAudioStream rate/channels/format members up to base class
: Move nsAudioStream rate/channels/format members up to base class
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla13
Assigned To: Robert O'Callahan (:roc) (Exited; email my personal email if necessary)
:
Mentors:
Depends on:
Blocks: 664918
  Show dependency treegraph
 
Reported: 2012-02-13 18:11 PST by Robert O'Callahan (:roc) (Exited; email my personal email if necessary)
Modified: 2012-02-15 08:47 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (4.37 KB, patch)
2012-02-13 18:14 PST, Robert O'Callahan (:roc) (Exited; email my personal email if necessary)
kinetik: review+
Details | Diff | Splinter Review

Description Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-02-13 18:11:23 PST

    
Comment 1 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-02-13 18:14:33 PST
Created attachment 596889 [details] [diff] [review]
fix
Comment 2 Matthew Gregan [:kinetik] 2012-02-13 18:20:51 PST
Comment on attachment 596889 [details] [diff] [review]
fix

Review of attachment 596889 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/nsAudioStream.h
@@ +129,5 @@
>    virtual PRInt32 GetMinWriteSize() = 0;
>  
> +  int GetRate() { return mRate; }
> +  int GetChannels() { return mChannels; }
> +  SampleFormat GetFormat() { return mFormat; }

Are these used in another patch?
Comment 3 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-02-13 18:26:20 PST
Yes.
Comment 4 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-02-13 20:59:44 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/135721f3720b
Comment 5 Phil Ringnalda (:philor) 2012-02-13 22:37:47 PST
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f81109133b5 for a fistful of orange in content/base/test/test_bug415860.html - your guess is better than mine about which one in the push was at fault.
Comment 6 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-02-14 02:21:51 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d19ab244ca
Comment 7 Marco Bonardo [::mak] 2012-02-15 08:47:58 PST
https://hg.mozilla.org/mozilla-central/rev/a8d19ab244ca

Note You need to log in before you can comment on or make changes to this bug.