726901 - change sut_tools/config.py to adjust resolution to 1600x1200 instead of 1680x1050

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

with the cleanup of our definition of a window in fennec, we now have a smaller window due to factoring in the URL bar.  This means our reftests fail to have enough room on a 1050 height window.

We need to adjust in config.py:
refHeight = 1600
refWidth = 1200

a related side note is those variables are mislabled.  It should be refWidth=1600 and refHeight=1200, but that is what is pushed down to adjustResolution.  We  could clean that up later, but I have purposefully fiddled the numbers the wrong way to match the functionality of the script.

Comment 1

[Mike Taylor [:bear]]

Attachment: change resolution for reftests

per joel on IRC:

[21:37]  <jmaher> that would allow us to test properly
[21:37]  <jmaher> oh fixing reftests to not require >=1000 pixels of height is an uphill battle
[21:39]  <pcwalton> jmaher: if you can do that, that would be great
[21:40]  <pcwalton> let me know if you need a force-gecko-height hack for the reftests
[21:41]  <jmaher> bear-afk: aki: do you guys have any thoughts on how difficult it would be to roll out a script to change which resolutions we use for reftests?
[21:41]  <bear-afk> we set the resolution already for some tests in one of the prep steps
[21:42]  <jmaher> bear-afk: yeah, I would like to change the values we set it to something different
[21:42]  <bear-afk> its more of a matter of making sure the resolution will "stick" for a headless tegra
[21:42]  <jmaher> tested twice on my local tegra tonight 
[21:42]  <jmaher> but it would need staging
[21:42]  <bear-afk> let me show you the line...
[21:43]  <jmaher> if we could change "refHeight = 1600;refWidth = 1200;" here: https://hg.mozilla.org/build/tools/file/28dcc684794d/sut_tools/config.py#l89
[21:44]  <bear-afk> https://hg.mozilla.org/build/tools/file/d8eb1a2c5d14/sut_tools/installApp.py#l144
[21:44]  <bear-afk> just remember that that reso was picked to allow the apk to install
[21:46]  <bear-afk> do you want me to poke the staging installApp step to set a different resolution to see how it does?
[21:47]  <jmaher> bear-afk: we just need to  change the stuff in config.py to be a 1600x1200 vs 1680x1050
[21:47]  <jmaher> and leave the rest of the logic alone


patch applied to dev-master01 locally

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

jmaher: is this a dup of bug#726829 ?

Comment 3

[Mike Taylor [:bear]]

I don't think the tegra (or devicemanager) likes this change:

argv: ['python', '/builds/sut_tools/config.py', '10.250.49.8', 'reftest']

connecting to: 10.250.49.8
reconnecting socket
devroot /mnt/sdcard/tests
results: {'screen': ['X:1024 Y:768']}
current resolution X:1024 Y:768
/builds/tegra-021/test/../proxy.flg
results: {'os': ['harmony-eng 2.2 FRF91 20101105.183900 test-keys']}
results: {'screen': ['X:1024 Y:768']}
INFO: we have a current resolution of 1024, 768
INFO: adjusting screen resolution to 1200, 1600 and rebooting
DEBUG: gCallbackData is:  on port: 50021
Creating server with 10.250.48.200:50021
Calling disconnect on callback server
. Got data back from agent: System rebooted


Shutting down server now
System rebooted


Waiting for tegra to come back...
Try 1
reconnecting socket
devroot /mnt/sdcard/tests
results: {'screen': ['X:1280 Y:720']}
current resolution X:1280 Y:720
/builds/tegra-021/test/../error.flg
Remote Device Error: current resolution X:1280 Y:720 does not match what was set X:1200 Y:1600

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

so the X value needs to be 1600 and the y value needs to be 1200.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 596900 [details] [diff] [review]
change resolution for reftests

Review of attachment 596900 [details] [diff] [review]:
-----------------------------------------------------------------

::: sut_tools/config.py
@@ +87,5 @@
>  errorFile = os.path.join(cwd, '..', 'error.flg')
>  proxyIP   = getOurIP()
>  proxyPort = calculatePort()
> +refWidth  = 1200 # x
> +refHeight = 1600 # y

just switch these values.

Comment 6

[Mike Taylor [:bear]]

(In reply to Joel Maher (:jmaher) from comment #5)
> Comment on attachment 596900 [details] [diff] [review]
> change resolution for reftests
> 
> Review of attachment 596900 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: sut_tools/config.py
> @@ +87,5 @@
> >  errorFile = os.path.join(cwd, '..', 'error.flg')
> >  proxyIP   = getOurIP()
> >  proxyPort = calculatePort()
> > +refWidth  = 1200 # x
> > +refHeight = 1600 # y
> 
> just switch these values.

I have swapped them

Comment 7

[Mike Taylor [:bear]]

Attachment: change resolution for reftests

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 597000 [details] [diff] [review]
change resolution for reftests

Review of attachment 597000 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me!  thanks

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

looking over the logs for the last 5 hours, I don't see any problems.

Comment 10

[Mike Taylor [:bear]]

Comment on attachment 597000 [details] [diff] [review]
change resolution for reftests

committed changeset 2231:71f25c728965

Comment 11

[Mike Taylor [:bear]]

deployed