Tidy up browser/app/Makefile.in and skip a shell execution

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 596973 [details] [diff] [review]
The fix

This patch does several things:

- Replaces the shell execution for APP_VERSION with a simple use of MOZ_APP_VERSION
- Groups DEFINES that aren't flag dependent in one section
- Tidies up the LOCAL_INCLUDES into one block rather than separate lines
- Removes the -DDEBUG flag to the splash.rc files, I couldn't see it being used anywhere.
- Removes the forced-copying (rather than symlink) of mangle and shlibsign for Mac bundles. We never use mangle, and shlibsign is used outside of the directory, but seems to work as a symlink anyway.

Comment 1

5 years ago
Try run for a91c6c033980 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a91c6c033980
Results (out of 28 total builds):
    success: 26
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bugzilla@standard8.plus.com-a91c6c033980
(Assignee)

Updated

5 years ago
Attachment #596973 - Flags: review?(khuey)
Attachment #596973 - Flags: review?(khuey) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/428ba14f09b6
Whiteboard: [inbound]
(Assignee)

Updated

5 years ago
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/428ba14f09b6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.