Last Comment Bug 726975 - Tidy up browser/app/Makefile.in and skip a shell execution
: Tidy up browser/app/Makefile.in and skip a shell execution
Status: RESOLVED FIXED
[inbound]
:
Product: Firefox
Classification: Client Software
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 13
Assigned To: Mark Banner (:standard8) (afk until 26th July)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-14 04:56 PST by Mark Banner (:standard8) (afk until 26th July)
Modified: 2012-02-22 10:42 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
The fix (3.68 KB, patch)
2012-02-14 04:56 PST, Mark Banner (:standard8) (afk until 26th July)
khuey: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) (afk until 26th July) 2012-02-14 04:56:09 PST
Created attachment 596973 [details] [diff] [review]
The fix

This patch does several things:

- Replaces the shell execution for APP_VERSION with a simple use of MOZ_APP_VERSION
- Groups DEFINES that aren't flag dependent in one section
- Tidies up the LOCAL_INCLUDES into one block rather than separate lines
- Removes the -DDEBUG flag to the splash.rc files, I couldn't see it being used anywhere.
- Removes the forced-copying (rather than symlink) of mangle and shlibsign for Mac bundles. We never use mangle, and shlibsign is used outside of the directory, but seems to work as a symlink anyway.
Comment 1 Mozilla RelEng Bot 2012-02-14 09:00:34 PST
Try run for a91c6c033980 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a91c6c033980
Results (out of 28 total builds):
    success: 26
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bugzilla@standard8.plus.com-a91c6c033980
Comment 2 Mark Banner (:standard8) (afk until 26th July) 2012-02-21 12:05:33 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/428ba14f09b6
Comment 3 Ed Morley [:emorley] 2012-02-22 10:42:28 PST
https://hg.mozilla.org/mozilla-central/rev/428ba14f09b6

Note You need to log in before you can comment on or make changes to this bug.