Tidy up browser/app/Makefile.in and skip a shell execution

RESOLVED FIXED in mozilla13

Status

defect
RESOLVED FIXED
7 years ago
5 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla13

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Posted patch The fixSplinter Review
This patch does several things:

- Replaces the shell execution for APP_VERSION with a simple use of MOZ_APP_VERSION
- Groups DEFINES that aren't flag dependent in one section
- Tidies up the LOCAL_INCLUDES into one block rather than separate lines
- Removes the -DDEBUG flag to the splash.rc files, I couldn't see it being used anywhere.
- Removes the forced-copying (rather than symlink) of mangle and shlibsign for Mac bundles. We never use mangle, and shlibsign is used outside of the directory, but seems to work as a symlink anyway.
Try run for a91c6c033980 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a91c6c033980
Results (out of 28 total builds):
    success: 26
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bugzilla@standard8.plus.com-a91c6c033980
Attachment #596973 - Flags: review?(khuey)
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/428ba14f09b6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 13 → mozilla13
You need to log in before you can comment on or make changes to this bug.