Last Comment Bug 726975 - Tidy up browser/app/ and skip a shell execution
: Tidy up browser/app/ and skip a shell execution
Product: Firefox
Classification: Client Software
Component: Build Config (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 13
Assigned To: Mark Banner (:standard8)
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2012-02-14 04:56 PST by Mark Banner (:standard8)
Modified: 2012-02-22 10:42 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

The fix (3.68 KB, patch)
2012-02-14 04:56 PST, Mark Banner (:standard8)
khuey: review+
Details | Diff | Splinter Review

Description User image Mark Banner (:standard8) 2012-02-14 04:56:09 PST
Created attachment 596973 [details] [diff] [review]
The fix

This patch does several things:

- Replaces the shell execution for APP_VERSION with a simple use of MOZ_APP_VERSION
- Groups DEFINES that aren't flag dependent in one section
- Tidies up the LOCAL_INCLUDES into one block rather than separate lines
- Removes the -DDEBUG flag to the splash.rc files, I couldn't see it being used anywhere.
- Removes the forced-copying (rather than symlink) of mangle and shlibsign for Mac bundles. We never use mangle, and shlibsign is used outside of the directory, but seems to work as a symlink anyway.
Comment 1 User image Mozilla RelEng Bot 2012-02-14 09:00:34 PST
Try run for a91c6c033980 is complete.
Detailed breakdown of the results available here:
Results (out of 28 total builds):
    success: 26
    warnings: 2
Builds (or logs if builds failed) available at:
Comment 3 User image Ed Morley [:emorley] 2012-02-22 10:42:28 PST

Note You need to log in before you can comment on or make changes to this bug.