This patch does several things: - Replaces the shell execution for APP_VERSION with a simple use of MOZ_APP_VERSION - Groups DEFINES that aren't flag dependent in one section - Tidies up the LOCAL_INCLUDES into one block rather than separate lines - Removes the -DDEBUG flag to the splash.rc files, I couldn't see it being used anywhere. - Removes the forced-copying (rather than symlink) of mangle and shlibsign for Mac bundles. We never use mangle, and shlibsign is used outside of the directory, but seems to work as a symlink anyway.
Try run for a91c6c033980 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=a91c6c033980 Results (out of 28 total builds): success: 26 warnings: 2 Builds (or logs if builds failed) available at: http://email@example.com
Attachment #596973 - Flags: review?(khuey)
Attachment #596973 - Flags: review?(khuey) → review+
Target Milestone: --- → Firefox 13
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.