726978 - Remove useless NS_New(Native)LocalFile calls in nsBrowserApp.cpp

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Bug 686466 made application.ini a static file. However, it missed removing some of the calls to NS_New(Native)LocalFile that were only required for reading the application.ini from disk when -app wasn't passed.

This patch removes that, it also removes some includes that are not required.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 596976 [details] [diff] [review]
The fix

Review of attachment 596976 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/Makefile.in
@@ -214,5 @@
>  else
>  	$(RM) $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/MacOS/$(PROGRAM)
>  	rsync -aL $(PROGRAM) $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/MacOS
>  endif
> -	-cp -L $(DIST)/bin/mangle $(DIST)/bin/shlibsign $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/$(APPFILES)

This does more than advertized. The nsBrowserApp.cpp part is also missing.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix v2

Ahem, it always helps to attach the right patch...

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 596991 [details] [diff] [review]
The fix v2

Review of attachment 596991 [details] [diff] [review]:
-----------------------------------------------------------------

You want to do that in mobile/xul/app/nsBrowserApp.cpp, and b2g/app/nsBrowserApp.cpp, too.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 596991 [details] [diff] [review]
The fix v2

Nit if we're doing this, we no longer use exePath in do_main, might as well stop calling it with that. (We still need to calc it for the XPCOM startup)

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix v3

Addresses the various comments. I've also pushed to try to confirm at least the mobile changes are right (I just applied the patch there).

Comment 6

[Mark Banner (:standard8)]

Landed on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a2efcfd53ff

Comment 7

[Mozilla RelEng Bot]

Try run for a2be684fa890 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a2be684fa890
Results (out of 31 total builds):
    success: 30
    warnings: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a2be684fa890

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/0a2efcfd53ff