Closed
Bug 727121
Opened 12 years ago
Closed 12 years ago
Java 1.7 build warnings
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file, 1 obsolete file)
2.88 KB,
patch
|
Details | Diff | Splinter Review |
/home/bgirard/mozilla/kiwifox/tree/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:304: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type HashMap jAccount.put(Constants.JSON_KEY_SYNCKEY, syncKey); ^ where K,V are type-variables: K extends Object declared in class HashMap V extends Object declared in class HashMap /home/bgirard/mozilla/kiwifox/tree/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:305: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type HashMap jAccount.put(Constants.JSON_KEY_ACCOUNT, username); ^ where K,V are type-variables: K extends Object declared in class HashMap V extends Object declared in class HashMap /home/bgirard/mozilla/kiwifox/tree/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:306: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type HashMap jAccount.put(Constants.JSON_KEY_PASSWORD, password); ^ where K,V are type-variables: K extends Object declared in class HashMap V extends Object declared in class HashMap /home/bgirard/mozilla/kiwifox/tree/mobile/android/base/sync/setup/activities/SetupSyncActivity.java:307: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type HashMap jAccount.put(Constants.JSON_KEY_SERVER, serverURL); ^ where K,V are type-variables: K extends Object declared in class HashMap V extends Object declared in class HashMap
Assignee | ||
Comment 1•12 years ago
|
||
Here's the version that's already in android-sync, and will land in the next drop. Feel free to land before then if you're blocked.
Assignee | ||
Comment 2•12 years ago
|
||
Here's another awful hack.
Attachment #597062 -
Attachment is obsolete: true
Comment 3•12 years ago
|
||
Comment on attachment 597107 [details] [diff] [review] Proposed patch. v2 Review of attachment 597107 [details] [diff] [review]: ----------------------------------------------------------------- This seems needlessly complicated. Was suppressing the unchecked warnings insufficient? I'm assuming we don't want to change org.json.simple.JSONObject.
Assignee | ||
Comment 4•12 years ago
|
||
> This seems needlessly complicated. Was suppressing the unchecked warnings
> insufficient?
For Java 7, yes. It seems to ignore that annotation in some circumstances. This is me and kats leaping around like madmen trying to find an incantation that will trick it.
Assignee | ||
Comment 5•12 years ago
|
||
I pushed a modified version of Kartikaya's patch, because nothing else worked: https://hg.mozilla.org/integration/mozilla-inbound/rev/85085eefcac8
Whiteboard: [inbound]
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/85085eefcac8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Updated•11 years ago
|
Product: Mozilla Services → Android Background Services
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•