Pass -Wno-return-type-c-linkage to clang

RESOLVED FIXED in mozilla13

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 597080 [details] [diff] [review]
Pass -Wno-return-type-c-linkage to clang

I am normally in favour of fixing warnings by changing the code or changing the compiler, but  clang's return-type-c-linkage is the complete oposite of what we do with jsval, so it is probably better to just disable it.
Attachment #597080 - Flags: review?(ted.mielczarek)

Comment 1

5 years ago
I ran into this today on Linux using a build pulled after r150418.

Looks like an unwanted change to build/macosx/common snuck into the patch up for review.
OS: Mac OS X → All
Hardware: x86 → All
Created attachment 597521 [details] [diff] [review]
Pass -Wno-return-type-c-linkage to clang

now without the bits in build/macosx/common.
Assignee: nobody → respindola
Attachment #597080 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #597080 - Flags: review?(ted.mielczarek)
Attachment #597521 - Flags: review?(ted.mielczarek)
Blocks: 574346
Attachment #597521 - Flags: review?(ted.mielczarek) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2046a1f46d40
https://hg.mozilla.org/mozilla-central/rev/2046a1f46d40
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
This change causes Xcode 4.0.2 (Mac OS X 10.6) to print many

warning: unknown warning option '-Wno-return-type-c-linkage' [-Wunknown-warning-option]


ireid% clang --version
Apple clang version 2.0 (tags/Apple/clang-139) (based on LLVM 2.9svn)
Target: x86_64-apple-darwin10
Thread model: posix

Comment 6

5 years ago
(In reply to Irving Reid (:irving) from comment #5)
> This change causes Xcode 4.0.2 (Mac OS X 10.6) to print many
> 
> warning: unknown warning option '-Wno-return-type-c-linkage'
> [-Wunknown-warning-option]

That's because Clang added the new warning only a few weeks ago in the not-yet-released 3.1 release.

Perhaps we could add -Wno-unknown-warning-option to the default Clang compiler flags...
You need to log in before you can comment on or make changes to this bug.