727167 - Firefox 10 needs update to official NSPR release 4.9

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Kai Engert (:KaiE:)]

We made a mistake when shipping Firefox 10 and the Extended Support Release, because of an oversight.

We violated the rule "never ship NSPR beta versions in official releases of Mozilla" by shipping NSPR 4.9 beta

This can cause confusion, at least in Linux distributions, because as of now, there is no such 4.9 release on the FTP server.

Furthermore, it creates confusion if we release NSPR 4.9 and the release has different behavior.

I request that we upgrade the Firefox 10 branch to the next release of NSPR, such as NSPR 4.9

I hope that NSPR 4.9 will be fully compatible with the beta that has been shipped, although there is currently discussion in bug 699567 for a last minute change.

My preference would be to release the old beta as NSPR 4.9 final release, the identical snapshot that has been shipped in Firefox 10. This way it would be 100% sure that anyone downloading NSPR 4.9 will get exactly what we shipped in Firefox 10. It would be a way to avoid having to upgrade the Firefox 10 branch.

Should NSPR 4.9 final be released with code that is different from 4.9 beta, then we must upgrade the ff 10 branch.

Comment 1

[Alex Keybl [:akeybl]]

(In reply to Kai Engert (:kaie) from comment #0)
> Should NSPR 4.9 final be released with code that is different from 4.9 beta,
> then we must upgrade the ff 10 branch.

What's changed between these two versions that warrants switching out the NSPR version for our ESR users? We didn't chemspill for this oversight, so it's difficult to make the case for a rule being violated as motivation for taking on ESR.

Comment 2

[Wan-Teh Chang]

Attachment: Diffs between NSPR_4_9_BETA4 and NSPR_4_9_RTM

akeybl: this is my fault.  Sorry about the problem I created.

The changes between NSPR_4_9_BETA4 (used in ESR) and NSPR_4_9_RTM
are very small, as this diffs file shows.

Comment 3

[Alex Keybl [:akeybl]]

(In reply to Wan-Teh Chang from comment #2)
> Created attachment 598056 [details] [diff] [review]
> Diffs between NSPR_4_9_BETA4 and NSPR_4_9_RTM
> 
> akeybl: this is my fault.  Sorry about the problem I created.
> 
> The changes between NSPR_4_9_BETA4 (used in ESR) and NSPR_4_9_RTM
> are very small, as this diffs file shows.

We don't plan to take NSPR release for FF10 as a chemspill, so is this bug just tracking taking NSPR 4.9 final for the next ESR? Is 4.9 now present in FF11?

Comment 4

[Kai Engert (:KaiE:)]

> We don't plan to take NSPR release for FF10 as a chemspill, so is this bug
> just tracking taking NSPR 4.9 final for the next ESR?

You mean, next ESR as in the next scheduled update for ESR like 10.0.3?
Yes, I would suggest that.
Thanks


> Is 4.9 now present in FF11?

Brian is about to land it any minute now (into both beta 11 and aurora 12), as part of bug 713936.
Thanks to Brian.

Comment 5

[Kai Engert (:KaiE:)]

> > Is 4.9 now present in FF11?

Yes. Now it's done.

Comment 6

[Daniel Veditz [:dveditz]]

We need to take the NSS 3.13.3 update on ESR and should bump this at the same time. Whatever we do this is version Linux distros will be shipping with (they use system NSPR and NSS libraries). Better if we keep up.

Comment 7

[Alex Keybl [:akeybl]]

Tracking for ESR - this should land ASAP to bring us in line with FF11. Please see https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for how to land on mozilla-esr10.

Comment 8

[Wan-Teh Chang]

Kai, could you land this on mozilla-esr10?  Thanks.

Comment 9

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/mozilla-esr10/rev/b449a2eee570