72717 - die Blue, die!

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Joe Hewitt (gone)]

The Blue theme must die.  For the interests of 0.8.1, Asa has asked me to simply
land something on the 0.8.1 branch to prevent blue from being built.  So I will
do that first and ask for reviews. Then, later on I'll actually cvs remove it
from the trunk.

Comment 1

[Joe Hewitt (gone)]

Attachment: patch to prevent building blue

Comment 2

[Blake Ross]

r=blake

Comment 3

[Asa Dotzler [:asa]]

a=asa.  Thanks Joe.

Comment 4

[Gilles Durys]

When it's done, I suppose bugs such as 66078 or 72033 can be resolved as WONTFIX ?

Comment 5

[Joe Hewitt (gone)]

fixed on branch.  Yes, from here on all Blue bugs should be marked WONTFIX.

Comment 6

[Peter "jag" Annema]

hewitt, we talked about a light-weight replacement for Blue. Is there anything
you or Netscape can help with?

The same goes for anyone else who feels this would be a nice challenge:
It doesn't need to be a shiny skin, just functional, quick, and (or is this just
wishful thinking?) low on memory use.

My idea behind this is that it can also be used as a (simple!) example of how to
skin chrome and I'm hoping it's pretty low maintainance (and thus more robust
than the more involved skins).

I should probably open a new RFE/bug for this :-)

Comment 7

[Andreas J. Koenig]

You guys just have no mercy. Blue was the only aesthetically pleasing skin,
friendly on resources, unintrusive, with the dignity of the plainness, 3D-free,
form follows function, etc., etc. Goodbye, my beloved skin!

Peter, I second your RFE if you post it and will vote for it if you let us know
which bug-ID it gets. Thanks!

Comment 8

[Asa Dotzler [:asa]]

Note that you can still pull by date from CVS and get the blue files (or just
grab and hold onto a build pre-removal)  Anyone interested is free to take and
maintain blue as a XPInstallable theme. 

I also like the idea of a simple theme with code that is as discoverable (for
new folks learning skinning) as possible.  

Comment 9

[hangas]

Themes Triage Team Marking nsbeta1+

Comment 10

[Joe Hewitt (gone)]

The forthcoming patch removes all references to the blue theme from various
build and install packaging files.  Of course, in addition to the patch I will
be doing a cvs remove of mozilla/themes/blue.

Comment 11

[Joe Hewitt (gone)]

Attachment: patch to kill blue

Comment 12

[Daniel Veditz [:dveditz]]

I don't get the nsbeta1+ for something that wasn't in the NS build anyway; 
adding nearest mozilla equiv for tracking though I suppose that's a moot point 
as this is about to be checked in.

r=dveditz

You missed a commented-out ";bin\chrome\blue\*" line in 
mozilla/xpinstall/packager/packages-win. It won't hurt anything to leave it, 
but it'd be nice if you could zap that one too.

Comment 13

[David Hyatt]

sr=hyatt.  You may fire at will.

Comment 14

[Joe Hewitt (gone)]

Blue is dead, long live Blue.

Comment 15

[Joe Hewitt (gone)]

Oh, by the way, if you ever get the urge to check out blue, I tagged it in the
tree as BLUETHEME_LASTGASP_20010410

Comment 16

[rbs]

It was forgotten to remove it from the 'View' & 'Themes' menus.

Comment 17

[Christian Mattar]

rbs:
I think those are dynamically generated during build time.
AFAIK you've got to change some RDF in your profile to remove these in already
existing profiles.

Comment 18

[Patty Mac]

Marking verified.