The default bug view has changed. See this FAQ.

Add a virtual destructor to WebGLExtension

RESOLVED FIXED in mozilla13

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 597155 [details] [diff] [review]
Add a virtual destructor to WebGLExtension

WebGLExtension is used as a base class and is deleted. It is possible that the code should be refactored so that we always delete a known base class, but I could not find an easy way to do it.

This patch adds a virtual destructor inline so that the base class destructors can inline it.
Attachment #597155 - Flags: review?(jmuizelaar)
Comment on attachment 597155 [details] [diff] [review]
Add a virtual destructor to WebGLExtension

This patch doesn't seem to match the bug.
Attachment #597155 - Flags: review?(jmuizelaar) → review-
Created attachment 597359 [details] [diff] [review]
correct patch
Assignee: nobody → respindola
Attachment #597155 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #597359 - Flags: review?(jmuizelaar)
Attachment #597359 - Flags: review?(jmuizelaar) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=34ba364fd1c8
https://hg.mozilla.org/mozilla-central/rev/34ba364fd1c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.