Closed Bug 727230 Opened 10 years ago Closed 10 years ago

Add a virtual destructor to WebGLExtension

Categories

(Core :: Canvas: WebGL, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file, 1 obsolete file)

WebGLExtension is used as a base class and is deleted. It is possible that the code should be refactored so that we always delete a known base class, but I could not find an easy way to do it.

This patch adds a virtual destructor inline so that the base class destructors can inline it.
Attachment #597155 - Flags: review?(jmuizelaar)
Comment on attachment 597155 [details] [diff] [review]
Add a virtual destructor to WebGLExtension

This patch doesn't seem to match the bug.
Attachment #597155 - Flags: review?(jmuizelaar) → review-
Attached patch correct patchSplinter Review
Assignee: nobody → respindola
Attachment #597155 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #597359 - Flags: review?(jmuizelaar)
Attachment #597359 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/34ba364fd1c8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.