Last Comment Bug 727230 - Add a virtual destructor to WebGLExtension
: Add a virtual destructor to WebGLExtension
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla13
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-14 13:14 PST by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2012-02-16 02:49 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add a virtual destructor to WebGLExtension (3.25 KB, patch)
2012-02-14 13:14 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
jmuizelaar: review-
Details | Diff | Review
correct patch (567 bytes, patch)
2012-02-15 03:13 PST, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
jacob.benoit.1: review+
Details | Diff | Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-02-14 13:14:23 PST
Created attachment 597155 [details] [diff] [review]
Add a virtual destructor to WebGLExtension

WebGLExtension is used as a base class and is deleted. It is possible that the code should be refactored so that we always delete a known base class, but I could not find an easy way to do it.

This patch adds a virtual destructor inline so that the base class destructors can inline it.
Comment 1 Jeff Muizelaar [:jrmuizel] 2012-02-14 16:15:57 PST
Comment on attachment 597155 [details] [diff] [review]
Add a virtual destructor to WebGLExtension

This patch doesn't seem to match the bug.
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-02-15 03:13:27 PST
Created attachment 597359 [details] [diff] [review]
correct patch
Comment 3 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-02-15 04:27:22 PST
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=34ba364fd1c8
Comment 4 Marco Bonardo [::mak] 2012-02-16 02:49:47 PST
https://hg.mozilla.org/mozilla-central/rev/34ba364fd1c8

Note You need to log in before you can comment on or make changes to this bug.