don't delete an interface

RESOLVED FIXED in mozilla13

Status

()

Core
Geolocation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 597156 [details] [diff] [review]
don't delete an interface

Currently we have a delete of nsIDOMGeoPositionCoords. This breaks -Werror builds with clang and looks very odd.

This patch changes the variables types to use nsGeoPositionCoords instead of nsIDOMGeoPositionCoords. This then requires a static_cast because of the autogenerated GetCoords.
Attachment #597156 - Flags: review?(doug.turner)
Blocks: 574346
The delete was introduced in bug 617965. ccing bent who also reviewed it.
Assignee: nobody → respindola
Status: NEW → ASSIGNED

Comment 2

6 years ago
Comment on attachment 597156 [details] [diff] [review]
don't delete an interface

there is no problem with GeoPositionAddress or GeoPosition?
(In reply to Doug Turner (:dougt) from comment #2)
> Comment on attachment 597156 [details] [diff] [review]
> don't delete an interface
> 
> there is no problem with GeoPositionAddress or GeoPosition?

We don't call delete on them. So at least there is not this problem :-)

Updated

6 years ago
Attachment #597156 - Flags: review?(doug.turner) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f91b74bfcb1f
https://hg.mozilla.org/mozilla-central/rev/f91b74bfcb1f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.