Closed Bug 727233 Opened 11 years ago Closed 11 years ago

don't delete an interface

Categories

(Core :: DOM: Geolocation, defect)

Product:
Core
Component:
DOM: Geolocation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file)

don't delete an interface
1.62 KB, patch
dougt
: review+
Details | Diff | Splinter Review 
Currently we have a delete of nsIDOMGeoPositionCoords. This breaks -Werror builds with clang and looks very odd.

This patch changes the variables types to use nsGeoPositionCoords instead of nsIDOMGeoPositionCoords. This then requires a static_cast because of the autogenerated GetCoords.
Attachment #597156 - Flags: review?(doug.turner)
The delete was introduced in bug 617965. ccing bent who also reviewed it.
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Comment on attachment 597156 [details] [diff] [review]
don't delete an interface

there is no problem with GeoPositionAddress or GeoPosition?
(In reply to Doug Turner (:dougt) from comment #2)
> Comment on attachment 597156 [details] [diff] [review]
> don't delete an interface
> 
> there is no problem with GeoPositionAddress or GeoPosition?

We don't call delete on them. So at least there is not this problem :-)
Attachment #597156 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/f91b74bfcb1f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.