Closed
Bug 727233
Opened 13 years ago
Closed 13 years ago
don't delete an interface
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
Currently we have a delete of nsIDOMGeoPositionCoords. This breaks -Werror builds with clang and looks very odd.
This patch changes the variables types to use nsGeoPositionCoords instead of nsIDOMGeoPositionCoords. This then requires a static_cast because of the autogenerated GetCoords.
Attachment #597156 -
Flags: review?(doug.turner)
|
Assignee | |
Updated•13 years ago
|
Blocks: clang-macosx
|
|
Assignee | |
Comment 1•13 years ago
|
||
The delete was introduced in bug 617965. ccing bent who also reviewed it.
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → respindola
Status: NEW → ASSIGNED
|
||
Comment 2•13 years ago
|
||
Comment on attachment 597156 [details] [diff] [review]
don't delete an interface
there is no problem with GeoPositionAddress or GeoPosition?
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #2)
> Comment on attachment 597156 [details] [diff] [review]
> don't delete an interface
>
> there is no problem with GeoPositionAddress or GeoPosition?
We don't call delete on them. So at least there is not this problem :-)
|
|
||
Updated•13 years ago
|
Attachment #597156 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•