727244 - dragging a link onto a tab results in a JS exception: Error: "draggedTab is undefined"

Status: VERIFIED FIXED

Description

[:Gavin Sharp [email: [e-mail]]]

STR:
1) Drag link from content area to the currently selected tab

Expected: link loads in tab, no JS exceptions
Actual: exception fired because draggedTab is undefined in the drop handler:

Error: draggedTab is undefined
Source File: chrome://browser/content/tabbrowser.xml
Line: 3518

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Created attachment 597179 [details] [diff] [review]
patch

Comment 2

[Frank Yan (:fryn)]

Comment on attachment 597179 [details] [diff] [review]
patch

A tiny mistake in Jez's patch for bug 465186. No biggie. :)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/a599bea9935a

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I landed this on aurora/beta since the test for the patch for bug 718203 depends on it:
https://hg.mozilla.org/releases/mozilla-beta/rev/1518b43a6f1b
https://hg.mozilla.org/releases/mozilla-aurora/rev/c00445fcd26d

Comment 5

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0

Comment 6

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0
BuildID: 20120314195616