Closed Bug 727244 Opened 13 years ago Closed 13 years ago

dragging a link onto a tab results in a JS exception: Error: "draggedTab is undefined"

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 13
Tracking Status
firefox11 --- verified
firefox12 --- verified

People

(Reporter: Gavin, Assigned: Gavin)

Details

(Whiteboard: [qa!])

Attachments

(1 file)

STR:
1) Drag link from content area to the currently selected tab

Expected: link loads in tab, no JS exceptions
Actual: exception fired because draggedTab is undefined in the drop handler:

Error: draggedTab is undefined
Source File: chrome://browser/content/tabbrowser.xml
Line: 3518
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #597179 - Flags: review?(fryn)
Comment on attachment 597179 [details] [diff] [review]
patch

A tiny mistake in Jez's patch for bug 465186. No biggie. :)
Attachment #597179 - Flags: review?(fryn) → review+
https://hg.mozilla.org/mozilla-central/rev/a599bea9935a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
I landed this on aurora/beta since the test for the patch for bug 718203 depends on it:
https://hg.mozilla.org/releases/mozilla-beta/rev/1518b43a6f1b
https://hg.mozilla.org/releases/mozilla-aurora/rev/c00445fcd26d
Whiteboard: [qa+]
Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Whiteboard: [qa+] → [qa+][qa!:11]
Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0
BuildID: 20120314195616
Status: RESOLVED → VERIFIED
Whiteboard: [qa+][qa!:11] → [qa!]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: