72740 - Page Info window needs menus

Status: VERIFIED WONTFIX

(SeaMonkey :: Page Info, defect, P4)

Description

[sairuh (rarely reading bugmail)]

the Page Info window needs menus...well, at least to close it. :) true, if the
window has a close widget in the corner, the user can use that --but it wouldn't
be in line with other mozilla windows.

Daniel, feel free to reassign if you're not the right person here.

Comment 1

[Warner Young]

Sairuh, wouldn't this apply to the Page Source window as well?

Comment 2

[Boris Zbarsky [:bzbarsky]]

doron's rewrite of the view source xul includes menus, iirc.

Comment 3

[Daniel Brooks [:db48x]]

hmmm. What would you put on these menus?

Fabian has already proposed putting two buttons at the bottom of the window, a
close button and a refresh button. The close button is obvious, and the refresh
button will reload all the information for whatever document is currently in the
window that opened page info, and would be very handy on pages where scripts
change the portions of the dom we are showing, like images and forms.

I'm not sure there's really any need for a menu bar here. Not only that, but
it'd look funny.

I am the right person to assign it to though.

Comment 4

[sairuh (rarely reading bugmail)]

buttons would be fine, but since this is a window and not a dialog [afaik],
shouldn't it have menus? cc'ing german/mpt for UI confirmation [or, denial]. in
any case, if menus are the way to go, i admit they'd be, ah, sparse: a File menu
that includes Close [and mebbe Quit?]... ;)

Comment 5

[Daniel Brooks [:db48x]]

Well, I dunno. Seems like it'd be a waste of time if you ask me. I tend to
consider it to be a dialog box. We even use dialog style windows. If it really
needs menus, and people express a desire to have menus, I suppose it's not
difficult, and I'll do it. Maybe.

Comment 6

[sairuh (rarely reading bugmail)]

i don't have any strong feeling about having menus in this feature. i guess just
wanted a more obvious way to close Page Info, other than the close widget --in
which case a button would suffice. i could either morph this bug [unless someone
else speaks up for needing menus], or file another one re: a close button. sorry
i wasn't clear to begin with!

Comment 7

[Matthew T (active 1999-2002)]

The Page Info window is a document/utility window, not a dialog. So it could 
have menus, if it needed to, but it doesn't.

Like any document/utility window without its own set of menus, the Page Info 
window should inherit the menus of the `hidden window' on Mac OS (with `Copy' 
and `Select All' in the `Edit' menu, and all the contents of the `Help' menu, 
enabled). But apart from that, it doesn't need any menus on any platform.

Neither should it have a button labelled `Close' -- no window or dialog should 
ever have such a button.

Comment 8

[Daniel Brooks [:db48x]]

so is this a WONTFIX then?

Comment 9

[sairuh (rarely reading bugmail)]

go ahead...

Comment 10

[Daniel Brooks [:db48x]]

my pleasure, really.

Comment 11

[sairuh (rarely reading bugmail)]

okeedoke.

Comment 12

[Damian Yerrick]

>Neither should it have a button labelled `Close' --
>no window or dialog should ever have such a button.

However, informational dialogs do have a button labeled "OK"
that closes the dialog.  Does that count?

Comment 13

[Matthew T (active 1999-2002)]

You are referring to note alerts, which do indeed have a solitary `OK' button.
However, Page Info is not a note alert, or a dialog for that matter. It's a
window, which is closed either with the window manager's close button or with
Ctrl+W.