If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Constants in Bugzilla::WebService::Constants should be available inside the templates similar to Bugzilla::Constants

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
WebService
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Bugzilla 4.4
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Currently Bugzilla/Template.pm allows all constants in Bugzilla::Constants to be passed to the templates if they need access to them. Constants in Bugzilla::WebService::Constants are not passed in. This could be useful to have access to for error messages, etc. such as in user-error.html.tmpl.

Patch coming

dkl
(Assignee)

Updated

6 years ago
Blocks: 725663
(Assignee)

Comment 1

6 years ago
Created attachment 597494 [details] [diff] [review]
Patch to allow access to webservice constants in templates (v1)
Attachment #597494 - Flags: review?(LpSolit)

Comment 2

6 years ago
Comment on attachment 597494 [details] [diff] [review]
Patch to allow access to webservice constants in templates (v1)

>+            WS_DISPATCH => \&Bugzilla::WebService::Constants::WS_DISPATCH, 

I really doubt we will ever need it to be accessible from templates. And in the rare case where we would, we should pass it to the template explicitly.

r=LpSolit with this line removed.
Attachment #597494 - Flags: review?(LpSolit) → review+

Updated

6 years ago
Severity: normal → enhancement
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
(Assignee)

Comment 3

6 years ago
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified Bugzilla/Template.pm
Committed revision 8115.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
No longer blocks: 725663
You need to log in before you can comment on or make changes to this bug.