Closed
Bug 727541
Opened 13 years ago
Closed 13 years ago
Constants in Bugzilla::WebService::Constants should be available inside the templates similar to Bugzilla::Constants
Categories
(Bugzilla :: WebService, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file)
|
1.98 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Currently Bugzilla/Template.pm allows all constants in Bugzilla::Constants to be passed to the templates if they need access to them. Constants in Bugzilla::WebService::Constants are not passed in. This could be useful to have access to for error messages, etc. such as in user-error.html.tmpl.
Patch coming
dkl
|
Assignee | |
Updated•13 years ago
|
Blocks: CVE-2012-0453
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #597494 -
Flags: review?(LpSolit)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 597494 [details] [diff] [review]
Patch to allow access to webservice constants in templates (v1)
>+ WS_DISPATCH => \&Bugzilla::WebService::Constants::WS_DISPATCH,
I really doubt we will ever need it to be accessible from templates. And in the rare case where we would, we should pass it to the template explicitly.
r=LpSolit with this line removed.
Attachment #597494 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•13 years ago
|
Severity: normal → enhancement
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
|
|
Assignee | |
Comment 3•13 years ago
|
||
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified Bugzilla/Template.pm
Committed revision 8115.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
No longer blocks: CVE-2012-0453
You need to log in
before you can comment on or make changes to this bug.
Description
•