Closed
Bug 727560
Opened 12 years ago
Closed 9 years ago
Hebrew diacritics are not displayed correctly since Firefox 10
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: amir.aharoni, Unassigned)
References
Details
Attachments
(7 files)
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0a2) Gecko/20120215 Firefox/12.0a2 Build ID: 20120215042007 Steps to reproduce: I opened a simple file with some Hebrew with diacritics (attached). Actual results: The diacritics were displayed somewhere to the side from where they are supposed to be. Expected results: The diacritics should have been displayed correctly.
Reporter | ||
Comment 1•12 years ago
|
||
A screenshot of LibreOffice and Aurora. LibreOffice is showing the same text in the same font correctly.
Updated•12 years ago
|
Attachment #597510 -
Attachment mime type: text/plain → text/html
Comment 2•12 years ago
|
||
Worksforme on Mac...
Component: General → Layout: Text
QA Contact: general → layout.fonts-and-text
Reporter | ||
Comment 3•12 years ago
|
||
It may be a Windows-only or an XP-only bug. It's hard for me to check now, but if i'm not mistaken, this started happening in Firefox 10 and the latest builds of Nightly and Aurora. Before that the diacritics were displayed correctly.
Comment 4•12 years ago
|
||
Apparently XP-only, at least I can't reproduce on 7.
Keywords: regressionwindow-wanted
Comment 5•12 years ago
|
||
WFM on Win7, too, though I notice that I'm seeing a different font than is shown in the screenshot. What is the font being used on XP? (Use fontinfo add-on...) Does it make any difference if you set gfx.font_rendering.harfbuzz.scripts to 7 in about:config (instead of the default value of 3)?
Reporter | ||
Comment 6•12 years ago
|
||
The font is Arial. Setting gfx.font_rendering.harfbuzz.scripts to 7 doesn't change the rendering.
Comment 7•12 years ago
|
||
If I do not misread str, regression window is as follows: And I cannot reproduce in Firefox12beta but reproduce in Aurora13.0a2 and Nightly14.0a1 on Windows XP only. Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/e61a169463c6 Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222095919 Bad: http://hg.mozilla.org/mozilla-central/rev/49956e0cc0bb Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222142417 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e61a169463c6&tochange=49956e0cc0bb Regression window(m-c) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/83c85131bcfe Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120222 Firefox/13.0a1 ID:20120222005219 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/063e67b9f910 Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120221 Firefox/13.0a1 ID:20120222022318 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=83c85131bcfe&tochange=063e67b9f910 Suspected: 063e67b9f910 Jonathan Kew — bug 722139 - Turn on harfbuzz shaper by default for Hebrew on all platforms. r=smontagu
Comment 8•12 years ago
|
||
The regression window is a little odd, considering comment 6 (which implies that harfbuzz doesn't have any effect on this) and the fact that the bug was originally reported earlier than the "last good" timestamp.
Comment 9•12 years ago
|
||
I suppose it's possible that harfbuzz exposed an already existing bug for some configurations of OS and installed fonts.
Comment 10•12 years ago
|
||
(In reply to Simon Montagu from comment #8) > The regression window is a little odd, considering comment 6 (which implies > that harfbuzz doesn't have any effect on this) and the fact that the bug was > originally reported earlier than the "last good" timestamp. Umm, In my WindowsXP gfx.font_rendering.harfbuzz.scripts in Nightli14.0a1 0,1,2,3 : OK. 4,5,6,7 : NG.
Comment 11•11 years ago
|
||
Linux Firefox 18.0.1 Gentoo Worked perfectly for years. Now diacritics are in offset. Test is available at[1], use culmus fonts. [1] http://www.mechon-mamre.org/c/ct/c0101.htm
Comment 12•11 years ago
|
||
Linux Firefox 10.0.111 Gentoo Perfect rendering. Test is available at[1], use culmus fonts. [1] http://www.mechon-mamre.org/c/ct/c0101.htm
Comment 13•11 years ago
|
||
Amir Aharoni, Can you please set platform to all or at least add Linux? Summary: Firefox-10 - OK. Firefox-17 - Regression. Firefox-18 - Regression. If you think this bug is Windows specific I will open a new bug for Linux. Thanks!
Reporter | ||
Comment 14•11 years ago
|
||
http://www.mechon-mamre.org/c/ct/c0101.htm looks good to me with Culmus fonts on Firefox 18 in Fedora 18 and in Windows XP.
Comment 15•11 years ago
|
||
(In reply to Amir Aharoni from comment #14) > http://www.mechon-mamre.org/c/ct/c0101.htm looks good to me with Culmus > fonts on Firefox 18 in Fedora 18 and in Windows XP. This is strange, can you attach a picture please? Do you have the original issue reported?
Comment 16•11 years ago
|
||
Sample with multiple fonts. Frank Ruehl CLM, David CLM shows offset. Liberation Sans, DeJaVu Serif behaves correctly. Guess: difference between type 1 fonts and true type fonts?
Updated•11 years ago
|
Attachment #709532 -
Attachment mime type: text/plain → text/html
Comment 17•11 years ago
|
||
I tried installing the current version of David CLM (from sourceforge, v 0.120, although the download archive was named culmus-0.130). The genesis.html sample looks pretty good here (viewing on OS X), although I notice one issue: just about every word contains at least one character (one of the Hebrew accent marks) that isn't supported in the David font, and so falls back to some other font on the system. This means that the results you see will vary depending what particular fallback font is found for those accents on your system. You might find that they look reasonably OK together - or you might not. It also means that David CLM, at least (and quite likely other fonts from the culmus package) is not really suitable for fully-accented Biblical Hebrew, as it does not support all the necessary characters.
Comment 18•11 years ago
|
||
Thank you for testing this! (In reply to Jonathan Kew (:jfkthame) from comment #17) > It also means that David CLM, at least (and quite likely other fonts from > the culmus package) is not really suitable for fully-accented Biblical > Hebrew, as it does not support all the necessary characters. However, how can we explain that all worked well in firefox-10?
Comment 19•11 years ago
|
||
genesis.html as viewed with firefox-10
Comment 20•11 years ago
|
||
genesis.html as viewed with firefox-17
Updated•11 years ago
|
Attachment #709710 -
Attachment description: /tmp/genesis-html-ff-17.png → genesis-html-ff-17.png
Comment 21•11 years ago
|
||
I get better results with Taamey Frank CLM and Taamey David CLM, in fact I only have these versions installed, and not the non-Taamey ones. I don't know if there's any fontconfig magic that will make the system use these fonts when "David" or "Frank Ruehl" is specified
Comment 22•11 years ago
|
||
(In reply to Simon Montagu from comment #21) > I get better results with Taamey Frank CLM and Taamey David CLM, in fact I > only have these versions installed, and not the non-Taamey ones. I don't > know if there's any fontconfig magic that will make the system use these > fonts when "David" or "Frank Ruehl" is specified Thank you for the hint, indeed these fonts are working correctly in firefox-10 and firefox-17. Not sure why the others worked in firefox-10. But I don't mind of using these.
Comment 23•9 years ago
|
||
Is there still an issue here with current Firefox releases?
Flags: needinfo?(amir.aharoni)
Reporter | ||
Comment 24•9 years ago
|
||
Sorry, I don't have easy access to a Windows machine. I totally trust Simon to test it.
Flags: needinfo?(amir.aharoni)
Comment 25•9 years ago
|
||
Simon, is there anything actionable to do here still?
Flags: needinfo?(smontagu)
Comment 26•9 years ago
|
||
As far as I know this problem no longer manifests.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(smontagu)
Resolution: --- → WORKSFORME
Updated•9 years ago
|
Keywords: regressionwindow-wanted
You need to log in
before you can comment on or make changes to this bug.
Description
•