uniformMatrix*fv handles its transpose argument incorrectly

RESOLVED FIXED in mozilla14

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 597539 [details] [diff] [review]
Patch v1

The argument should be converted to a boolean, but it is converted to an int32_t. This is observable from script by passing

{ valueOf: function() { throw "Error"; } }

This should simply be treated as true, but currently will (I believe) propagate the exception back to user code.

This should be tested in the conformance test suite, but I have no idea how to write a good test for this stuff. Benoit, could you perhaps have a look?
Attachment #597539 - Flags: review?(bjacob)
Attachment #597539 - Flags: review?(bjacob) → review+
Blocking webgl-needed-tests so I can't forget about this.
Blocks: 728357
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f41d103e5bbe
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
No longer blocks: 728357
Whiteboard: webgl-test-needed
Added a test for all WebGL functions taking boolean arguments:

https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/misc/boolean-argument-conversion.html
Whiteboard: webgl-test-needed
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.