Last Comment Bug 727590 - uniformMatrix*fv handles its transpose argument incorrectly
: uniformMatrix*fv handles its transpose argument incorrectly
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-15 13:25 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2016-02-15 12:34 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.82 KB, patch)
2012-02-15 13:25 PST, :Ms2ger (⌚ UTC+1/+2)
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-02-15 13:25:48 PST
Created attachment 597539 [details] [diff] [review]
Patch v1

The argument should be converted to a boolean, but it is converted to an int32_t. This is observable from script by passing

{ valueOf: function() { throw "Error"; } }

This should simply be treated as true, but currently will (I believe) propagate the exception back to user code.

This should be tested in the conformance test suite, but I have no idea how to write a good test for this stuff. Benoit, could you perhaps have a look?
Comment 1 Benoit Jacob [:bjacob] (mostly away) 2012-02-18 11:23:19 PST
Blocking webgl-needed-tests so I can't forget about this.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-03-16 06:36:55 PDT
https://hg.mozilla.org/mozilla-central/rev/f41d103e5bbe
Comment 3 Benoit Jacob [:bjacob] (mostly away) 2012-05-28 12:29:32 PDT
Added a test for all WebGL functions taking boolean arguments:

https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/misc/boolean-argument-conversion.html

Note You need to log in before you can comment on or make changes to this bug.