727590 - uniformMatrix*fv handles its transpose argument incorrectly

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

The argument should be converted to a boolean, but it is converted to an int32_t. This is observable from script by passing

{ valueOf: function() { throw "Error"; } }

This should simply be treated as true, but currently will (I believe) propagate the exception back to user code.

This should be tested in the conformance test suite, but I have no idea how to write a good test for this stuff. Benoit, could you perhaps have a look?

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Blocking webgl-needed-tests so I can't forget about this.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f41d103e5bbe

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Added a test for all WebGL functions taking boolean arguments:

https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/misc/boolean-argument-conversion.html