Closed Bug 727590 Opened 10 years ago Closed 9 years ago

uniformMatrix*fv handles its transpose argument incorrectly

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
The argument should be converted to a boolean, but it is converted to an int32_t. This is observable from script by passing

{ valueOf: function() { throw "Error"; } }

This should simply be treated as true, but currently will (I believe) propagate the exception back to user code.

This should be tested in the conformance test suite, but I have no idea how to write a good test for this stuff. Benoit, could you perhaps have a look?
Attachment #597539 - Flags: review?(bjacob)
Attachment #597539 - Flags: review?(bjacob) → review+
Blocking webgl-needed-tests so I can't forget about this.
https://hg.mozilla.org/mozilla-central/rev/f41d103e5bbe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
No longer blocks: webgl-needed-tests
Whiteboard: webgl-test-needed
You need to log in before you can comment on or make changes to this bug.