727595 - Clang build broken due to JS_ASSERT changes from bug 717540

Status: RESOLVED INVALID

(Core :: MFBT, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Compiling a build from mozilla-central with clang is currently broken due to the fix on bug 717540.

Output:

ld: warning: ignoring file /System/Library/Frameworks//QuickTime.framework/QuickTime, file was built for unsupported file format which is not the architecture being linked (x86_64)
ld: warning: could not create compact unwind for _ffi_call_unix64: does not use RBP or RSP based frame
Undefined symbols for architecture x86_64:
  "_JS_Assert", referenced from:
      mozilla::GuardObjectNotificationReceiver::~GuardObjectNotificationReceiver() in nsProxyEvent.o
      mozilla::GuardObjectNotificationReceiver::~GuardObjectNotificationReceiver() in nsProxyEventObject.o
      mozilla::GuardObjectNotificationReceiver::~GuardObjectNotificationReceiver() in nsProxyObjectManager.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 1

[Jeff Walden [:Waldo]]

As I said on IRC, I'm pretty sure you just need to nuke your objdir from orbit and rebuild.  JS_Assert now exists only as a #define to MOZ_Assert, so it should never be the case that you'll see a JS_Assert symbol, as seems to be happening with this error message.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Just to add: I did a clobber already which didn't help. Now it's still building with a really fresh obj dir. Will report back the results in a bit.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, this was actually helping. Why can a clobber not be enough in some situations? Is it a bug in the build system?

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

(In reply to Henrik Skupin (:whimboo) [away 02/17 - 02/26] from comment #3)
> Ok, this was actually helping. Why can a clobber not be enough in some
> situations? Is it a bug in the build system?

Any change that requires manual intervention is a bug in the build system IMHO, but I would be really impressed if it was fixed.