727610 - Full Screen doesn't hide ActionBar in Honeycomb+

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

After installing the full-screen add-on and going full screen, the action bar is not hidden in post-honeycomb devices.
Also, the status bar should dim during full screen.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This hides the action bar in ICS.
The code is moved into BrowserToolbar for modularity.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 597559 [details] [diff] [review]
Patch

go!

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b6ba04315303

Comment 4

[Matt Brubeck (:mbrubeck)]

Note that this makes the options menu inaccessible in full screen mode on Honeycomb/ICS.  I updated my Full Screen add-on to include "Exit Full Screen" in the context menu, so you can long-press anywhere on a page to get out of full screen:

http://hg.mozilla.org/users/mbrubeck_mozilla.com/fullscreen/rev/71195182be1a

The new version is awaiting review at AMO:

https://addons.mozilla.org/en-US/android/addon/full-screen-252573/versions/3.2

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b6ba04315303

Comment 6

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-02-27)
-device: Samsung Galaxy Tab 10.1
-OS: Android 3.1