72766 - Shared libraries must be explicitly linked against libc

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[jes]

Hi

The current build system does not link shared libraries against libc when
building under Linux. Instead it relies on the other shared objects to pull in
libc.

The problem is that on some architectures functions such as fstat() and
fstat64() are inline functions which are only available in libc_nonshared.a.
Hence in order to be able to get a real function version included it is
necessary to explicitly link against libc which will also include
libc_nonshared.a.

Please change the Makefiles to explicitly link against libc `-lc' when linking
any of the shared libraries.

Thanks
Jes

Comment 1

[Lawrence Walton]

Hello I am having a simular if not the same problem.
I have edited the Makefile, with no luck.
Love to look at another Makefile.

Comment 2

[cls]

Attachment: Add -lc to LIBS/OS_LIBS for mozilla/nspr

Comment 3

[Matthew Cline]

The patch in the attachment seems to solve the problem for me.

Comment 4

[Lawrence Walton]

The patch worked for me too, took me a little while, had to do a clobber after.
:)

Comment 5

[cls]

Patch has been checked in.  Marking fixed.

Comment 6

[Jon Granrose]

verified.

Comment 7

[Franz.Sirl-kernel]

The fix is actually wrong and may break binary backwards compatibility (seen on Linux/PPC).  On Linux there are 2 possibilities to correctly link against libc:    1. Use gcc/g++ for linking (that's what mozilla does) which will autoadd the  correct -l options for ld 2. Use ld for linking and add -lgcc -lc -lgcc for C and g++2, or add -lgcc_s -lc -lgcc_s for g++3  The bug Jes was reporting is probably some Makefile using ld directly instead of linking with gcc/g++.   

Comment 8

[Franz.Sirl-kernel]

Attachment: Fixup wrong -lc uses

Comment 9

[hacker formerly known as [e-mail]]

.

Comment 10

[Wan-Teh Chang]

Comment on attachment 91271 [details] [diff] [review]
Fixup wrong -lc uses

r=wtc.	This patch looks correct to me.  What do you think, cls?

Comment 11

[hacker formerly known as [e-mail]]

Looks fine to me.  Looking back, when jes reported this bug, we were using $(LD)
to link shared libs on NSPR so adding -lc was correct then.  The weird glibc/gcc
interaction makes me glad that we switched to using $(CC) to link. :)

Comment 12

[hacker formerly known as [e-mail]]

This patch has been checked into the NSPR trunk, the
NSPRPUB_PRE_4_2_CLIENT_BRANCH branch & the mozilla trunk.