727730 - Add support for Share Link context menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I am not happy with the blatant code/copy in this patch, so I am open to better ways to reuse the code.

I plan to post a patch with a test as soon as I land the "Open Link in Tab" tests

Comment 1

[Matt Brubeck (:mbrubeck)]

Comment on attachment 597703 [details] [diff] [review]
patch

>+    linkShareableContext: {
>+      matches: function linkOpenableContextMatches(aElement) {

should be "function linkShareableContextMatches(...)".

I'd like to move to a system like XUL fennec where several of the "selectors" share data.  I can file a followup bug for that.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

made the name change:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b88b81086a76

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b88b81086a76

Comment 4

[Camelia Urian]

Nightly 13.0a1 (2012-02-21)
Device: Samsung Nexus S - Android 2.3.6

Verified fixed: when long tapping on a link from a webpage, the "Share Link" option is listed in context menu, and also when long tapping on a link from TopSites/Bookmarks/History the "Share" option is listed in the context menu.

Comment 5

[Camelia Urian]

Test case added to litmus in BFT's - Context Menu: https://litmus.mozilla.org/show_test.cgi?id=50339