Closed Bug 727739 Opened 13 years ago Closed 13 years ago

Disabling an Adblock Plus filter rule on a page's domain creates a zombie compartment

Categories

(WebExtensions :: General, defect)

Product:
WebExtensions
Component:
General
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dbcooper.nz, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:13.0a1) Gecko/20120215 Firefox/13.0a1 Build ID: 20120215031155 Steps to reproduce: Add this filter to ABP: ||yui.yahooapis.com Open a tab and go to http://movies.yahoo.com Use ABP's "open blockable items" command. Find an item blocked by the above filter and choose "disable on yahoo.com". Confirm that the yui.yahooapis.com items are now unblocked (you may need to reload the page). Open an about:memory tab. Close the movies.yahoo.com tab. Wait 2 minutes and click "minimise memory usage" 3 times. Actual results: The movies.yahoo.com compartment never goes away. Zombie alert. Expected results: The compartment should have gone.
Blocks: LeakyAddons, ZombieCompartments
Adblock Plus version: 2.0.4a.3410 Element Hiding Helper version: 1.2.2a.407
I'm not 100% sure, but it looks like a dupe of Bug 718127 but in the another direction (adding a filter rule vs removing a filter rule).
@Loic: No, it is unrelated. Using the menu item is unnecessary, simply opening the context menu is enough. On the one hand this is a trivial issue - the context menu has some state that depends on the web page and that state isn't cleared when the context menu is closed. I will fix this. What's strange about this however: the zombie compartment remains even after the blockable items list is closed and its compartment (chrome://adblockplus/content/ui/sidebar.xul) is garbage collected. I don't see why that would happen and wonder whether it is related to bug 721319.
Status: UNCONFIRMED → NEW
Ever confirmed: true
The Adblock Plus issue has been fixed: https://hg.adblockplus.org/adblockplus/rev/4f6b3874ace0. I don't consider it critical, particularly with bug 726994 around, meaning that it will ship with the next regular update.
(In reply to Wladimir Palant from comment #4) > The Adblock Plus issue has been fixed: > https://hg.adblockplus.org/adblockplus/rev/4f6b3874ace0. I don't consider it > critical, particularly with bug 726994 around, meaning that it will ship > with the next regular update. Hi Wladimir, when is the next update scheduled for release? (so I know when to check back on the bug)
Unless there is an emergency it will take two months or something like this - the current development focus is on Adblock Plus for Chrome. If you simply need to test the changes and verify that they fix the issues you can find development builds under https://adblockplus.org/devbuilds/adblockplus/.
Component: Untriaged → Add-ons
Product: Firefox → Tech Evangelism
Version: 13 Branch → unspecified
Wladimir: when can we expect the fixed version to be published?
Wladimir: ping.
I am preparing a release right now. Given that a bunch of strings need to be translated - we will most likely release in two weeks.
Wladimir, what is the status of this bug?
Adblock Plus 2.1 has been released: https://addons.mozilla.org/addon/adblock-plus/versions/#version-2.1
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.