72776 - Right Click should cancel scrollbar thumb dragging operations

Status: NEW

(Core :: XUL, enhancement)

Description

[timeless]

this bug is a derivative from 
Bugzilla Bug 22175 Need to be able to cancel dragging of scrollbar thumb

This bug is marked PC/All. this bug is designed to annoy [e-mail]

Preffered implementation creates a preference [(right?) click cancels drag 
event] and sets it to true in all.js with an override coming from mac's all.js 
override file.

Comment 1

[Jesse Ruderman]

Why would this need to be disabled on the Mac?

Comment 2

[Matthew Tuck [:CodeMachine]]

Any chance we can extend this and bug #72775 to all dragging operations?

Comment 3

[Eric Vaughan]

targeting

Comment 4

[:deanis74]

Does it from the UI side of things if we do this on a mouse up instead of mouse 
down?  I've got this working on a mouse-down, but if the pointer is over the 
document window the drag is cancelled but then a context menu appears on 
mouse-up (on Windows, at least).  If I wait until the mouse up, I should be 
able to eat the event.

Comment 5

[:deanis74]

I've been unable to stop the event from passing through to the document window.  
I've tried returning NS_ERROR_BASE in HandleEvent() and also setting various 
flags on the event, but with no luck.  Other than that, I have this working.  
Should I attach the patch, then when this is checked in open another bug on the 
context menu appearing?

Comment 6

[Matthew T (active 1999-2002)]

I think this should really apply on mousedown, not on mouseup. Mousedown with 
the primary (left) button begins the drag, mousedown with the secondary (right) 
button cancels the drag.

I agree with the other Matthew T -- this should apply to all drags, not just to 
scrollbar thumbs. I also don't see why this shouldn't apply to the Mac as well 
(for those Mac users who have multi-button mice).

Comment 7

[:deanis74]

mpt - see bug 70279 for the meta bug about cancelling drag/scroll actions.

Would you hate me, though, if I did this on mouse up?  I just see it as being 
less problematic in the situation I described, as soon as I figure out how to 
eat that event.

Comment 8

[Matthew T (active 1999-2002)]

I don't hate anybody. As long as your code is an improvement over the current 
situation, and as long as this bug is kept open (or a less important bug is 
filed) to change the cancelling from mouseup to mousedown, then certainly your 
patch should be checked in.

Comment 9

[Adam Masri]

This is not a bug, it is an enhancement to current behavior. It would be useful
on all platforms that support multi-button mice (including the Mac), but should
not take precedence over fixing true UI bugs on the major platforms and
therefore should be left to the future to fix. Please see my comments in bug
72775 to see that the requested behavior is not HIG compliant on any platform,
according to developer documentation I've studied. However, bug 22175 is an
actual bug, and should be receiving everyone's attention to fix.

- Adam

Comment 10

[timeless]

Adam: people supply fixes based on their personal interests.  If Dean wants to 
fix this bug instead of that bug then it's his right.  Don't dictate to him or 
any other developer unless you are their corporate manager.

Comment 11

[Adam Masri]

timeless, this isn't a bug, it's an RFE. But of course, Dean's willing to work
on whatever he wishes.

- Adam

Comment 12

[:deanis74]

Argh.  I could add this functionality if I could eat the right-click after the 
scroll bar gets it.  How the heck do I do that??

Comment 13

[Chad Austin]

This should fix some aspects of bug 48037?

Comment 14

[Asa Dotzler [:asa]]

*** Bug 205368 has been marked as a duplicate of this bug. ***

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.