727879 - [km] fix review comments from registration bug

Status: VERIFIED FIXED

(Mozilla Localizations :: km / Khmer, defect)

Description

[Axel Hecht [:Pike]]

There are still a few issues open from the initial review in bug 551886 comment 57:

Quote:

In browser/defines.inc, the contributors look wrong. In toolkit/defines.inc, the language name sounds wrong, clearly this isn't Khmer as spoken in the US?

In toolkit/chrome/global/intl.properties:
general.useragent.locale should be km
intl.accept_languages should be localized to list km, and other languages likely spoken by people in myanmar, if applicable. Arky, can you assist here?
intl.menuitems.insertseparatorbeforeaccesskeys should be true, not a translation thereof.

Comment 1

[Vannak Eng]

i just correct them to ខ្មែរ (km) so that is correct?

Comment 2

[Axel Hecht [:Pike]]

If you're talking about toolkit/defines.inc, for Khmer, you don't need to suffix that with a code. In en-US, it's English (US), the code just clarifies the variant of English. In Khmer, that'd be just ខ្មែរ.

Looking at http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/rev/e58d43e6c278, you didn't fix intl.menuitems.insertseparatorbeforeaccesskeys yet. That should literally be the English word "true", not a khmer word.

The rest of the changes look fine for this bug.

Comment 3

[Vannak Eng]

i just made it true in stead of ពិត. and i'm going to commit it again.

Comment 4

[Vannak Eng]

here are what i have done please check them here.
http://hg.mozilla.org/releases/l10n/mozilla-beta/km//rev/7b280a3dedc8
http://hg.mozilla.org/releases/l10n/mozilla-aurora/km//rev/38524a81ad96

Comment 5

[Vannak Eng]

i think it is fixed

Comment 6

[Axel Hecht [:Pike]]

Confirmed, thanks.