728125 - Google Translate dictation doesn't work

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[ferongr]

Google Translate has a feature that dictates untranslated or translated text, activated by clicking the small speaker icon. This feature doesn't seem to work in the latest Nightlies, while it works in Aurora, Beta and release channels.

STR
1. Go to translate.google.com
2. Enter a word in the left text input
3. Click the speaker icon on the bottom right of the left  text input once it appears

Expected result: Entered text is dictated by a machine generated voice synth.

Actual result: Nothing happens.

My connection has been very slow for the past week so I can't run mozregression, sorry :(

Comment 1

[Alice0775 White]

Regression window(m-c)
Last good:
http://hg.mozilla.org/mozilla-central/rev/4b9608fd670c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120207 Firefox/13.0a1 ID:20120207224449
First bad:
http://hg.mozilla.org/mozilla-central/rev/06b063c001b6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120208 Firefox/13.0a1 ID:20120208042354
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4b9608fd670c&tochange=06b063c001b6


Regression window(m-i)
Last good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c9bbbe2acb37
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120207 Firefox/13.0a1 ID:20120207141549
First bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4e6f683d3006
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120207 Firefox/13.0a1 ID:20120207142551
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c9bbbe2acb37&tochange=4e6f683d3006
Triggered by:
4e6f683d3006	Josh Aas — Bug 723379: Be more strict about not instantiating plugin instances before they have an object frame. Also fix a bug causing object frame creation to fail. r=bz

Comment 2

[Josh Aas]

As you'd expect given the bug that regressed this, we're failing to create an nsPluginInstanceOwner due to not having an object frame.

Comment 3

[Johnathan Nightingale [:johnath]]

Boris - you nom'd this for tracking-12 and tracking-13, but my understanding of the changesets is that this only started happening in 13 nightlies. To me, that looks like tracking-firefox12-, tracking-firefox13+, but I want to double check.

Comment 4

[Boris Zbarsky [:bzbarsky]]

The nom for 12 was a mistake, yeah.  Sorry about that....

Comment 5

[Josh Aas]

On Aurora we create an object frame for the Flash instance on Google Translate. On trunk we don't, so the problem is not with our object frame requirement. This is another case where we don't create an object frame when we should.

Comment 6

[Josh Aas]

Attachment: fix v1.0

This fixes the problem, and also fixes a number of other bugs in which video is reportedly not playing (esp. on CNN.com). I'm not sure this patch is 100% correct yet, and I should write a test, so not requesting review yet.

Comment 8

[Josh Aas]

Comment on attachment 599725 [details] [diff] [review]
fix v1.0

This patch has a bug in it. Working on a new patch.

Comment 9

[Josh Aas]

Fixed now that the fix for bug 731040 has landed.

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

Verified Fixed on win32 x 64 using hourly build from m-c based on cset:

https://hg.mozilla.org/mozilla-central/rev/08c0c1440171