728126 - provide non-flush version of nsComputedDOMStyle

Status: NEW

(Core :: DOM: CSS Object Model, defect)

Description

[alexander :surkov (:asurkov)]

(spun off bug 714579 comment#21)

It could look like:

1) add nsComputedDOMStyle* dom::Element::GetComputedStyle(bool aDoFlush = false). Bool argument points whether layout should be flushed or not.
2) extend nsComputedDOMStyle to provide methods for styling getting, for example Margin(css::Side).
2.1) one version to get a string representation of style, for example, Margin(css::Side, nsAString& aString)
2.2) second version to get a value object. That could be nsIDOMCSSValue* or preferable an instance of class similar to nsROCSSPrimitiveValue (dexpcomed version), for example, css::PrimitiveValue Margin(css::Side)

Alternatively
1a) add nsComputedDOMStyle* dom::Element::GetComputedStyle()
2a) add methods like described in 2) with layout flush argument like:
css::PrimitiveValue Margin(css::Side, bool aDoFlush)

Ah, and please remove accessible/src/base/Style.h introduced in bug 714579

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

We shouldn't have a non-flushing version of nsComputedDOMStyle because internal code should just be getting data it wants from style structs.  Or are you referring to further exposing nsComputedDOMStyle::GetStyleContextForElementNoFlush ?

Comment 2

[alexander :surkov (:asurkov)]

Accessibility needs string representations of styles that's what nsComputedDOMStyle knows how to do this. So, nsComputedDOMStyle::GetStyleContextForElementNoFlush is not enough for a11y, I meant we do this (see bug 714579) but we dupe the code of nsComputedDOMStyle.