Closed Bug 728221 Opened 10 years ago Closed 10 years ago

IonMonkey: Don't inline monitored calls or calls with type barriers

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Fixes ~10 jit-test failures (mostly TI failures) with --ion-eager -n, matches JM and does not (noticeably) regress SS/V8.

Note that I didn't add this to canEnterInlinedScript so that we can later more easily support polymorphic call sites.
Attachment #598232 - Flags: review?(dvander)
Comment on attachment 598232 [details] [diff] [review]
Patch

Out of curiosity why is this needed?
Attachment #598232 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/24951fdc836f

(In reply to David Anderson [:dvander] from comment #1)
> 
> Out of curiosity why is this needed?

If a JSOP_CALL has a type barrier, we have to check the type of the return value against the observed type set and update TI info if needed. jsop_call_inline could probably call pushTypeBarrier, but I just went with the simplest fix since it doesn't seem to matter for performance.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.