728221 - IonMonkey: Don't inline monitored calls or calls with type barriers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Fixes ~10 jit-test failures (mostly TI failures) with --ion-eager -n, matches JM and does not (noticeably) regress SS/V8.

Note that I didn't add this to canEnterInlinedScript so that we can later more easily support polymorphic call sites.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 598232 [details] [diff] [review]
Patch

Out of curiosity why is this needed?

Comment 2

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/projects/ionmonkey/rev/24951fdc836f

(In reply to David Anderson [:dvander] from comment #1)
> 
> Out of curiosity why is this needed?

If a JSOP_CALL has a type barrier, we have to check the type of the return value against the observed type set and update TI info if needed. jsop_call_inline could probably call pushTypeBarrier, but I just went with the simplest fix since it doesn't seem to matter for performance.