Closed Bug 728350 Opened 8 years ago Closed 8 years ago

Updated Telemetry help->about message to match notification message

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: lmandel, Assigned: tchevalier)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Telemetry])

Attachments

(2 files, 2 obsolete files)

Telemetry currently has an opt-in notification in product. An opt-out notification for Nightly and Aurora users is being added in bug 725407. Telemetry also has text in the help->about dialog (bug 701182). The message for the two notifications matches in terms of detail. The messages are:

opt-in
"Will you help improve %1$S by sending anonymous information about performance, hardware characteristics, feature usage, and browser customizations to %2$S?"

opt-out
"$PRODUCTNAME sends information about performance, hardware, usage and customizations back to Mozilla to help improve Firefox."

The Telemetry help->about message should match the messages that we use in our notification messages. Specifically, I would like to see the about dialogs updated to use the following text:

It automatically sends information about performance, hardware, usage and customizations back to &vendorShortName; to help make &brandShortName; better.
Okay, I'm on it :) Should I update message on mobile as well? (bug 702284)
Yes. For now let's use the same message on mobile. We may revisit the mobile message after we come up with the appropriate notification message for mobile in bug 728340.
Attached patch Patch V1 (obsolete) — Splinter Review
Attachment #598346 - Flags: review?(lmandel)
Comment on attachment 598346 [details] [diff] [review]
Patch V1

Review of attachment 598346 [details] [diff] [review]:
-----------------------------------------------------------------

This is the change I would like. Can you confirm with a screenshot that the extra text hasn't affected the overall appearance of the about dialog?
Attachment #598346 - Flags: review?(lmandel) → review+
(In reply to Lawrence Mandel [:lmandel] from comment #4)
> Comment on attachment 598346 [details] [diff] [review]
> Patch V1
> 
> Review of attachment 598346 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is the change I would like. Can you confirm with a screenshot that the
> extra text hasn't affected the overall appearance of the about dialog?

Thanks Lawrence. I anticipated this, the build is being compiled. :)
Comment on attachment 598346 [details] [diff] [review]
Patch V1

You'll need to change the entity name here (warningDesc.telemetryDesc?), since the string is semantically different, and that's the only way we have of notifying localizers of such changes.
Attachment #598346 - Flags: review+ → feedback+
Attached image Screenshot
Attachment #598346 - Attachment is obsolete: true
Attached patch PatchV2 (obsolete) — Splinter Review
Bug for the background issue is bug 712636.
Attachment #598381 - Flags: review?(gavin.sharp)
Comment on attachment 598381 [details] [diff] [review]
PatchV2

You'll also need to change the reference to the entity in the LOCALIZATION NOTE. r=me with that.
Attachment #598381 - Flags: review?(gavin.sharp) → review+
Attached patch PatchV2Splinter Review
Attachment #598384 - Flags: review?(gavin.sharp)
Attachment #598381 - Attachment is obsolete: true
Attachment #598384 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → theo.chevalier11
This looks ready to land. Can someone please push to Mozilla inbound?
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [Telemetry] → [Telemetry][checkin-needed]
Version: 10 Branch → unspecified
Whiteboard: [Telemetry][checkin-needed] → [Telemetry]
https://hg.mozilla.org/mozilla-central/rev/2d2525447715
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
Depends on: 743979
You need to log in before you can comment on or make changes to this bug.