728350 - Updated Telemetry help->about message to match notification message

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Telemetry currently has an opt-in notification in product. An opt-out notification for Nightly and Aurora users is being added in bug 725407. Telemetry also has text in the help->about dialog (bug 701182). The message for the two notifications matches in terms of detail. The messages are:

opt-in
"Will you help improve %1$S by sending anonymous information about performance, hardware characteristics, feature usage, and browser customizations to %2$S?"

opt-out
"$PRODUCTNAME sends information about performance, hardware, usage and customizations back to Mozilla to help improve Firefox."

The Telemetry help->about message should match the messages that we use in our notification messages. Specifically, I would like to see the about dialogs updated to use the following text:

It automatically sends information about performance, hardware, usage and customizations back to &vendorShortName; to help make &brandShortName; better.

Comment 1

[Théo Chevalier]

Okay, I'm on it :) Should I update message on mobile as well? (bug 702284)

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

Yes. For now let's use the same message on mobile. We may revisit the mobile message after we come up with the appropriate notification message for mobile in bug 728340.

Comment 3

[Théo Chevalier]

Attachment: Patch V1

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 598346 [details] [diff] [review]
Patch V1

Review of attachment 598346 [details] [diff] [review]:
-----------------------------------------------------------------

This is the change I would like. Can you confirm with a screenshot that the extra text hasn't affected the overall appearance of the about dialog?

Comment 5

[Théo Chevalier]

(In reply to Lawrence Mandel [:lmandel] from comment #4)
> Comment on attachment 598346 [details] [diff] [review]
> Patch V1
> 
> Review of attachment 598346 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is the change I would like. Can you confirm with a screenshot that the
> extra text hasn't affected the overall appearance of the about dialog?

Thanks Lawrence. I anticipated this, the build is being compiled. :)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 598346 [details] [diff] [review]
Patch V1

You'll need to change the entity name here (warningDesc.telemetryDesc?), since the string is semantically different, and that's the only way we have of notifying localizers of such changes.

Comment 7

[Théo Chevalier]

Attachment: Screenshot

Comment 8

[Théo Chevalier]

Attachment: PatchV2

Bug for the background issue is bug 712636.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 598381 [details] [diff] [review]
PatchV2

You'll also need to change the reference to the entity in the LOCALIZATION NOTE. r=me with that.

Comment 10

[Théo Chevalier]

Attachment: PatchV2

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

This looks ready to land. Can someone please push to Mozilla inbound?

Comment 12

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2525447715

Comment 13

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/2d2525447715