Updated Telemetry help->about message to match notification message

RESOLVED FIXED in Firefox 14

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lmandel, Assigned: tchevalier)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Telemetry])

Attachments

(2 attachments, 2 obsolete attachments)

Telemetry currently has an opt-in notification in product. An opt-out notification for Nightly and Aurora users is being added in bug 725407. Telemetry also has text in the help->about dialog (bug 701182). The message for the two notifications matches in terms of detail. The messages are:

opt-in
"Will you help improve %1$S by sending anonymous information about performance, hardware characteristics, feature usage, and browser customizations to %2$S?"

opt-out
"$PRODUCTNAME sends information about performance, hardware, usage and customizations back to Mozilla to help improve Firefox."

The Telemetry help->about message should match the messages that we use in our notification messages. Specifically, I would like to see the about dialogs updated to use the following text:

It automatically sends information about performance, hardware, usage and customizations back to &vendorShortName; to help make &brandShortName; better.
(Assignee)

Comment 1

5 years ago
Okay, I'm on it :) Should I update message on mobile as well? (bug 702284)
Yes. For now let's use the same message on mobile. We may revisit the mobile message after we come up with the appropriate notification message for mobile in bug 728340.
(Assignee)

Comment 3

5 years ago
Created attachment 598346 [details] [diff] [review]
Patch V1
Attachment #598346 - Flags: review?(lmandel)
Comment on attachment 598346 [details] [diff] [review]
Patch V1

Review of attachment 598346 [details] [diff] [review]:
-----------------------------------------------------------------

This is the change I would like. Can you confirm with a screenshot that the extra text hasn't affected the overall appearance of the about dialog?
Attachment #598346 - Flags: review?(lmandel) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Lawrence Mandel [:lmandel] from comment #4)
> Comment on attachment 598346 [details] [diff] [review]
> Patch V1
> 
> Review of attachment 598346 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is the change I would like. Can you confirm with a screenshot that the
> extra text hasn't affected the overall appearance of the about dialog?

Thanks Lawrence. I anticipated this, the build is being compiled. :)
Comment on attachment 598346 [details] [diff] [review]
Patch V1

You'll need to change the entity name here (warningDesc.telemetryDesc?), since the string is semantically different, and that's the only way we have of notifying localizers of such changes.
Attachment #598346 - Flags: review+ → feedback+
(Assignee)

Comment 7

5 years ago
Created attachment 598379 [details]
Screenshot
Attachment #598346 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Created attachment 598381 [details] [diff] [review]
PatchV2

Bug for the background issue is bug 712636.
Attachment #598381 - Flags: review?(gavin.sharp)
Comment on attachment 598381 [details] [diff] [review]
PatchV2

You'll also need to change the reference to the entity in the LOCALIZATION NOTE. r=me with that.
Attachment #598381 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 10

5 years ago
Created attachment 598384 [details] [diff] [review]
PatchV2
Attachment #598384 - Flags: review?(gavin.sharp)
Attachment #598381 - Attachment is obsolete: true
Attachment #598384 - Flags: review?(gavin.sharp) → review+

Updated

5 years ago
Assignee: nobody → theo.chevalier11
(Assignee)

Updated

5 years ago
Blocks: 712636
Blocks: 702284
This looks ready to land. Can someone please push to Mozilla inbound?
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [Telemetry] → [Telemetry][checkin-needed]
Version: 10 Branch → unspecified
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2525447715
Target Milestone: --- → Firefox 14
Whiteboard: [Telemetry][checkin-needed] → [Telemetry]
https://hg.mozilla.org/mozilla-central/rev/2d2525447715
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk

Updated

5 years ago
Depends on: 743979
You need to log in before you can comment on or make changes to this bug.