728372 - Get chunk compilation to work on x64

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Currently chunk compilation is disabled on x64, due to the extra complexity involved in infallibly patching jumps between different chunks and shim labels.  This can cause huge and confusing performance differences on sites which want to use chunked compilation, e.g. bug 727956 comment 3.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch (3fa51ff647cb)

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 598342 [details] [diff] [review]
patch (3fa51ff647cb)

Review of attachment 598342 [details] [diff] [review]:
-----------------------------------------------------------------

z

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 598342 [details] [diff] [review]
patch (3fa51ff647cb)

Review of attachment 598342 [details] [diff] [review]:
-----------------------------------------------------------------

(Whoops, hit enter too quick, meant to say): If you wanted to make it simpler you could also just always do the long jump.

Comment 4

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b8ad7252ccb

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b8ad7252ccb

Comment 6

[Ed Morley [:emorley]]

Could this have been the cause of:

Regression :( Dromaeo (SunSpider) decrease 15% on WINNT 6.1 x64 Firefox
-----------------------------------------------------------------------
    Previous: avg 1024.380 stddev 64.070 of 30 runs up to revision 561771f01881
    New     : avg 871.117 stddev 24.855 of 5 runs since revision b8e7474374d5
    Change  : -153.262 (15% / z=2.392)
    Graph   : http://mzl.la/zIYrCm 

Unfortunately (like the other day), not possible to reduce the range further using talos, since Win x64 talos not running on inbound. Range for the merge to m-c was:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=561771f01881&tochange=b8e7474374d5

Comment 7

[Brian Hackett [Laid off!]]

If there was no similar regression on other x64 platforms, then no.  This bug will affect all x64 platforms equally (and is all in codegen, so there shouldn't be any wacky OS dependent stuff).