728507 - Importing Opera Bookmarks fails for new Opera Installs

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[philippe (part-time)]

The option to import Opera Bookmarks does not appear in the import window.

New Opera installations store all user data in ~/Library/Opera and ~/Library/Application Support/Opera. Bookmarks are in ~/Library/Opera

Older Opera created a folder in ~/Library/Preferences/Opera Preferences. When the user upgrades from older versions, this folder is converted in a symlink pointing to ~/Library/Opera. But said symlink is not created for new (Opera) users.

BookmarkImportDlgController.mm looks at ~/Library/Preferences/Opera Preferences
http://mxr.mozilla.org/camino/source/camino/src/bookmarks/BookmarkImportDlgController.mm#104

Comment 1

[philippe (part-time)]

Opera change the location of the folder with Opera 11.5

Comment 2

[philippe (part-time)]

Attachment: patch

This fixes it: adding the path to the Opera 11.5 user folder

Comment 3

[Chris Lawson (gone)]

A quick glance at the code looks good to me, but I won't be able to test until Sunday afternoon at the earliest. Since this is pretty trivial, though, if Stuart says it's OK, I'm fine with having it go straight to sr if it'll get things fixed faster.

Comment 4

[Stuart Morgan]

Comment on attachment 598497 [details] [diff] [review]
patch

sr=smorgan

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 598497 [details] [diff] [review]
patch

r=ardissone; I sullied an account that had never seen Opera to verify ;-)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/af7f52c6c428

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

These are going to be in 2.1.3 instead.