Closed
Bug 728521
Opened 12 years ago
Closed 12 years ago
Remove unused 'gIMAPService' const/var in (IMAP) tests
Categories
(MailNews Core :: Networking: IMAP, defect, P4)
MailNews Core
Networking: IMAP
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird 13.0
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
|
15.04 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
1) Most are 'const gIMAPService', which should better be 'const kIMAPService'. 2) Most are even unused. Are these actually useful? (As in triggering something.) Document/Improve/Cleanup.
|
||
Comment 1•12 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #0) > 1) Most are 'const gIMAPService', which should better be 'const > kIMAPService'. > 2) Most are even unused. Are these actually useful? (As in triggering > something.) Agreed that they seem unused. Should be a simple & quick test to confirm that. I probably wouldn't fuss about g versus k unless I was actually in there touching the code for some other purposes, and even then I probably wouldn't bother changing it.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 13.0
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=86a0a8f1f477 succeeds (so far).
Attachment #599032 -
Flags: review?(mbanner)
|
|
||
Updated•12 years ago
|
Attachment #599032 -
Flags: review?(mbanner) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 599032 [details] [diff] [review] (Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars [Checked in: Comment 3] http://hg.mozilla.org/comm-central/rev/c1a6a7f12583
Attachment #599032 -
Attachment description: (Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars → (Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars
[Checked in: Comment 3]
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Summary: Review 'gIMAPService' in (IMAP) tests → Remove unused 'gIMAPService' const/var in (IMAP) tests
|
|
Assignee | |
Comment 4•12 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1329850326.1329851394.28818.gz Linux comm-central test xpcshell on 2012/02/21 10:52:06 V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•