Remove unused 'gIMAPService' const/var in (IMAP) tests

VERIFIED FIXED in Thunderbird 13.0

Status

MailNews Core
Networking: IMAP
P4
trivial
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
Thunderbird 13.0
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
1) Most are 'const gIMAPService', which should better be 'const kIMAPService'.
2) Most are even unused. Are these actually useful? (As in triggering something.)

Document/Improve/Cleanup.
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> 1) Most are 'const gIMAPService', which should better be 'const
> kIMAPService'.
> 2) Most are even unused. Are these actually useful? (As in triggering
> something.)

Agreed that they seem unused. Should be a simple & quick test to confirm that.

I probably wouldn't fuss about g versus k unless I was actually in there touching the code for some other purposes, and even then I probably wouldn't bother changing it.
(Assignee)

Updated

5 years ago
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Comment 2

5 years ago
Created attachment 599032 [details] [diff] [review]
(Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars
[Checked in: Comment 3]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=86a0a8f1f477
succeeds (so far).
Attachment #599032 - Flags: review?(mbanner)
Attachment #599032 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 599032 [details] [diff] [review]
(Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars
[Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/c1a6a7f12583
Attachment #599032 - Attachment description: (Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars → (Av1) Remove unused 'gIMAPService' const/var, Remove some duplicated vars [Checked in: Comment 3]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Summary: Review 'gIMAPService' in (IMAP) tests → Remove unused 'gIMAPService' const/var in (IMAP) tests
(Assignee)

Comment 4

5 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1329850326.1329851394.28818.gz
Linux comm-central test xpcshell on 2012/02/21 10:52:06

V.Fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.