728629 - canvas2D fillText & strokeText should not throw exceptions when non-finite doubles are passed for the position

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[jonathan.winterflood]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120216082320

Steps to reproduce:

Called canvas 2D context method strokeText or fillText with NaN, undefine or Infinity as a coordinate:
var c=document.createElement('canvas');
document.body.appendChild(c);
c.getContext("2d").strokeText("Hello",NaN,50); // Substitute fillText, undefined, Infinity

a null is ignored and seems treated as 0 (this may be an acceptable behaviour)


Actual results:

Exception "Error: An invalid or illegal string was specified" was thrown.


Expected results:

An exception along the lines of 'Error: An invalid x coordinate was specified: NaN' (substitute y, undefined, Infinity... as appropriate) should be thrown.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Actually, the behavior the spec calls for here is to silently ignore the strokeText call.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

More still? *sigh*

Comment 3

[Mina Almasry]

Attachment: strokeText.patch

This is no longer an issue. Attached a test case to show that.

Comment 4

[Mina Almasry]

Should I checkin this or no?

Comment 5

[Mina Almasry]

Should I checkin this or no?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fwiw, chances are the switch to WebIDL bindings is what fixed this.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Uh, tests are good, so I'd say yes?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed18294b150c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed18294b150c