728633 - [SeaMonkey] "browser_bug591465.js | Test timed out"

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329533748.1329538419.29635.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/17 18:55:48
+
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1329548148.1329554173.27000.gz
WINNT 5.2 comm-aurora debug test mochitest-other on 2012/02/17 22:55:48
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_bug591465.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser-window/browser_bug591465.js | Found unexpected add-ons manager window still open
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1329553178.1329556949.32205.gz
Linux comm-beta debug test mochitest-other on 2012/02/18 00:19:38
doesn't seem affected.

I assume the regression happened when "addon 2" was pushed lower than the window by adding some new addons: I'm not sure when that happened exactly.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Add an ensureElementIsVisible() call, to support SeaMonkey

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 598608 [details] [diff] [review]
(Av1) Add an ensureElementIsVisible() call, to support SeaMonkey

Ping for review.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 598608 [details] [diff] [review]
(Av1) Add an ensureElementIsVisible() call, to support SeaMonkey

Review of attachment 598608 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/browser/browser_bug591465.js
@@ +190,5 @@
>  
>  add_test(function() {
>    var el = get_addon_element(gManagerWindow, "[e-mail]");
> +  // This (disabled) element is at the end of the list...
> +  el.parentNode.ensureElementIsVisible(el);

Should really add this to all cases where get_addon_element() is used in this test.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Add ensureElementIsVisible() calls, to support having more items [Checked in: Comments 5 and 9]

Av1, with comment 3 suggestion(s).

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 600854 [details] [diff] [review]
(Av2) Add ensureElementIsVisible() calls, to support having more items
[Checked in: Comments 5 and 9]

https://hg.mozilla.org/mozilla-central/rev/2dc40eb83023


[Approval Request Comment]
Regression caused by (bug #): (old)
User impact if declined: None, but perma-orange (timeout) on SeaMonkey.
Testing completed (on m-c, etc.): This comment.
Risk to taking this patch (and alternatives if risky): None, test only.
String changes made by this patch: None.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1329553178.
> 1329556949.32205.gz
> Linux comm-beta debug test mochitest-other on 2012/02/18 00:19:38
> doesn't seem affected.

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1330251719.1330257061.17889.gz
OS X 10.6 comm-beta debug test mochitest-other on 2012/02/26 02:21:59

is affected: SM-Beta log was "broken" previously.

Comment 7

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1330349051.1330354920.29678.gz
Linux comm-central-trunk debug test mochitest-other on 2012/02/27 05:24:11

V.Fixed

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 600854 [details] [diff] [review]
(Av2) Add ensureElementIsVisible() calls, to support having more items
[Checked in: Comments 5 and 9]

[Triage Comment]
approving as it is a test only patch

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 600854 [details] [diff] [review]
(Av2) Add ensureElementIsVisible() calls, to support having more items
[Checked in: Comments 5 and 9]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e8c002b5c984
http://hg.mozilla.org/releases/mozilla-beta/rev/63716fae7193

Comment 10

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1330509264.1330514338.13867.gz
Linux comm-aurora debug test mochitest-other on 2012/02/29 01:54:24

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1330489986.1330493973.10985.gz
OS X 10.6 comm-beta debug test mochitest-other on 2012/02/28 20:33:06

seamonkey2.9 and seamonkey2.8: verified.