728719 - NSSUTIL_GetVersion, undefined reference during linking

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Kai Engert [:KaiE:]]

I attempt to build Firefox with NSS 3.13.2, including a local change that calls the recently added function NSSUTIL_GetVersion()

I get an error while linking:
  hidden symbol NSSUTIL_GetVersion isn't defined.

I inspected the code, but everything looks right to me.

(If I remove the call NSSUTIL_GetVersion(), but keep other calls like NSS_GetVersion(), it links fine, which makes it even more spooky.)

I ended up experimenting. If I move the declaration away from it's current position in nssutil.h, moving it to secoid.h, then the linker succeeds.

At both places (current nonworking place and experimental other place), the declaration is wrapped inside SEC_BEGIN_PROTOS / SEC_END_PROTOS.

To my surprise the problem cannot be reproduced using NSS command line utilities. Still having the declaration of NSSUTIL_GetVersion(), adding a call to NSSUTIL_GetVersion() inside cmd/pp/pp.c, linking and execution work fine.


I'm not sure if we should spend analyzing what happens here.
Maybe we should simply move it to the other header.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch v1

Comment 2

[Kai Engert [:KaiE:]]

Ok, it's not a bug in NSS.

The problem is that nssutil.h is not listed as a system header when building Mozilla, and that probably causes those symbols to be hidden. The important detail is, I tried adding the file to the config/system-headers and js/src/config/system-headers files, and the build succeeds.

Thanks a lot to Mike Hommey for pointing me to this solution.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Patch v2

Comment 4

[Kai Engert [:KaiE:]]

Thanks. I will land this together with bug 673381 when that one is ready.

Comment 5

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f3c7742021c

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/1f3c7742021c