Closed
Bug 728904
Opened 14 years ago
Closed 14 years ago
prefix telemetry constants starting by A11Y
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: surkov, Assigned: capella)
References
Details
(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])
Attachments
(1 file)
2.82 KB,
patch
|
surkov
:
review+
tbsaunde
:
feedback+
|
Details | Diff | Splinter Review |
rename to:
1) ISIMPLE_DOM_USAGE -> A11Y_ISIMPLEDOM_USAGE
2) IACCESSIBLE_TABLE_USAGE -> A11Y_IA2TABLE_USAGE
3) XFORMS_ACCESSIBLE_USED -> A11Y_XFORMS_USAGE
Reporter | ||
Updated•14 years ago
|
Summary: prefix telementry constants starting by A11Y → prefix telemetry constants starting by A11Y
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Initial patch... good local build and accessibility runtests were successful.
Attachment #600417 -
Flags: review?(surkov.alexander)
![]() |
||
Comment 2•14 years ago
|
||
Automated tests don't cover telemetry. It is tricky to test this manually (requires installing about:telemetry addon, and causing the relevant code paths to be active).
Reporter | ||
Updated•14 years ago
|
Attachment #600417 -
Flags: review?(surkov.alexander)
Attachment #600417 -
Flags: review+
Attachment #600417 -
Flags: feedback?(trev.saunders)
Updated•14 years ago
|
Attachment #600417 -
Flags: feedback?(trev.saunders) → feedback+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++] → [autoland-try][good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
![]() |
||
Updated•14 years ago
|
Whiteboard: [autoland-try][good first bug][mentor=surkov.alexander@gmail.com][lang=c++] → [autoland-in-queue][good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
![]() |
||
Comment 3•14 years ago
|
||
Autoland Patchset:
Patches: 600417
Branch: mozilla-central => try
Destination: http://hg.mozilla.org/try/pushloghtml?changeset=357fe3967d14
Try run started, revision 357fe3967d14. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=357fe3967d14
Reporter | ||
Comment 4•14 years ago
|
||
I pushed it on try already, later I will land it withing bug 725259, canceling autorun
Whiteboard: [autoland-in-queue][good first bug][mentor=surkov.alexander@gmail.com][lang=c++] → [good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
Assignee | ||
Comment 5•14 years ago
|
||
Oh! ok, thanks. So it's closed and done from my perspective.
![]() |
||
Comment 6•14 years ago
|
||
Try run for 357fe3967d14 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=357fe3967d14
Results (out of 14 total builds):
exception: 10
failure: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-357fe3967d14
Reporter | ||
Comment 7•14 years ago
|
||
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•