728914 - [km] search plugins regressed

Status: RESOLVED FIXED

(Mozilla Localizations :: km / Khmer, defect)

Description

[Axel Hecht [:Pike]]

In http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/diff/e58d43e6c278/browser/searchplugins/list.txt, list.txt was changed back to only include en wikipedia instead of km.

Please make sure that you don't regress this in the future, and attach a patch here for review of restoring the state we came up with in 709140

Comment 1

[Vannak Eng]

Attachment: patch for search plugin

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 599027 [details] [diff] [review]
patch for search plugin

Review of attachment 599027 [details] [diff] [review]:
-----------------------------------------------------------------

Is this the old patch?

The fix we need right now is just list.txt, the changes to wikipedia-km.xml shouldn't apply.

Please attach a patch against the current state of the repository.

::: browser/searchplugins/list.txt
@@ +7,1 @@
>  yahoo

This part looks good.

::: browser/searchplugins/wikipedia-km.xml
@@ +14,5 @@
> +        template="http://km.wikipedia.org/w/api.php">
> +     <Param name="action" value="opensearch"/>
> +     <Param name="search" value="{searchTerms}"/>
> +   </Url>
> +   </SearchPlugin>

This doesn't seem to be a patch against the current state of the repository. The current version has both the line endings and the new shortname.

Comment 3

[Vannak Eng]

Attachment: I think this one is correct

sorry for the first patch that i took from the old one.

Comment 4

[Milos Dinic [:Milos]]

Comment on attachment 599422 [details] [diff] [review]
I think this one is correct

Review of attachment 599422 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/searchplugins/list.txt
@@ +2,5 @@
>  bing
>  eBay
>  google
>  twitter
> +wikipedia-km

Looks good.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 599422 [details] [diff] [review]
I think this one is correct

Review of attachment 599422 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, too. Please land this patch with check-in comment like the ones you used before, like "bug 728914, use wikiped0-km again, r=Pike, Milos"

Comment 6

[Vannak Eng]

I have landed it already