Closed Bug 728953 Opened 10 years ago Closed 10 years ago

nsWindow::DispatchEvent doesn't forward some events when maybe it should

Categories

(Core :: Widget: Win32, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

nsWindow::DispatchEvent doesn't forward NS_MOVE or NS_XUL_CLOSE events to the view event handler, sayiing the view ignores these. But nsViewManager::DispatchEvent does have cases for these event types.

Bug 513162 introduced this code.
Should we just forward all events to the view callback (and send the few that matter to the base window)?
(In reply to Timothy Nikkel (:tn) from comment #1)
> Should we just forward all events to the view callback (and send the few
> that matter to the base window)?

Yep.
Ok. Try server pending.
Attached patch patchSplinter Review
Good on try.
Assignee: nobody → tnikkel
Attachment #599015 - Flags: review?(jmathies)
Attachment #599015 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/de9d907064e3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.