Closed Bug 729041 Opened 9 years ago Closed 9 years ago

Remove nsEditorParserObserver

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: hsivonen, Assigned: charles.wh.chan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mentor=hsivonen][lang=C++])

Attachments

(1 file)

I don't know what nsEditorParserObserver is supposed to do but the HTML5 parser doesn't support notifying it.

Since failure to notify this observer hasn't been noticed as a problem in over a year, let's remove this mystery observer.
Blocks: 729050
Whiteboard: [mentor=hsivonen][lang=C++]
It used to stop you editing frameset documents. The caller was rewritten 10 years ago but nobody noticed that the replacement code didn't use it...
[Removal is probably build system changes only, no C++ knowledge needed.]
Here's the patch file. There is no dependency on the the Makefile either, therefore, simply require the use of 'hg remove ...'
Attachment #604814 - Flags: review?
Attachment #604814 - Flags: review? → review+
Do you have mercurial push access? Should this be now treated as [checkin-needed]?
Assignee: nobody → charles.wh.chan
Hello Henri, I do not have push access. Shall I set the [checkin-needed] flag as you  have stated above?
(In reply to Charles Chan from comment #5)
> Hello Henri, I do not have push access. Shall I set the [checkin-needed]
> flag as you  have stated above?

Normally the next step would have been adding "checkin-needed" to the keyword field. However, knowing that you would have done it next, I went ahead and treated this bug as if it had been marked checkin-needed already.

That is, I landed the patch to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2931fcb5ae

(I tweaked the commit message to include ". r=hsivonen." and changed the separator punctuation after the bug number to use the more common convention.)

Thank you.

(This bug will be marked FIXED once mozilla-inbound is merged into mozilla-central.)
Thanks! Henri.
https://hg.mozilla.org/mozilla-central/rev/ee2931fcb5ae
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.