Remove nsEditorParserObserver

RESOLVED FIXED in mozilla14

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hsivonen, Assigned: Charles Chan)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=hsivonen][lang=C++])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
I don't know what nsEditorParserObserver is supposed to do but the HTML5 parser doesn't support notifying it.

Since failure to notify this observer hasn't been noticed as a problem in over a year, let's remove this mystery observer.
(Reporter)

Updated

6 years ago
Blocks: 729050
(Reporter)

Updated

6 years ago
Whiteboard: [mentor=hsivonen][lang=C++]

Comment 1

6 years ago
It used to stop you editing frameset documents. The caller was rewritten 10 years ago but nobody noticed that the replacement code didn't use it...

Comment 2

6 years ago
[Removal is probably build system changes only, no C++ knowledge needed.]
(Assignee)

Comment 3

6 years ago
Created attachment 604814 [details] [diff] [review]
Bug 729041: Patch-1

Here's the patch file. There is no dependency on the the Makefile either, therefore, simply require the use of 'hg remove ...'
Attachment #604814 - Flags: review?
(Reporter)

Updated

6 years ago
Attachment #604814 - Flags: review? → review+
(Reporter)

Comment 4

6 years ago
Do you have mercurial push access? Should this be now treated as [checkin-needed]?
Assignee: nobody → charles.wh.chan
(Assignee)

Comment 5

6 years ago
Hello Henri, I do not have push access. Shall I set the [checkin-needed] flag as you  have stated above?
(Reporter)

Comment 6

6 years ago
(In reply to Charles Chan from comment #5)
> Hello Henri, I do not have push access. Shall I set the [checkin-needed]
> flag as you  have stated above?

Normally the next step would have been adding "checkin-needed" to the keyword field. However, knowing that you would have done it next, I went ahead and treated this bug as if it had been marked checkin-needed already.

That is, I landed the patch to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2931fcb5ae

(I tweaked the commit message to include ". r=hsivonen." and changed the separator punctuation after the bug number to use the more common convention.)

Thank you.

(This bug will be marked FIXED once mozilla-inbound is merged into mozilla-central.)
(Assignee)

Comment 7

6 years ago
Thanks! Henri.
https://hg.mozilla.org/mozilla-central/rev/ee2931fcb5ae
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.