Closed
Bug 729071
Opened 13 years ago
Closed 13 years ago
Port |Bug 668865 - Store _scheme & _host in _serializeHistoryEntry| to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file)
3.49 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Session restore currently does this:
1. iterates over each entry in shistory and serializes some parts of it
1a. namely it grabs the entry.URI.spec (and other stuff)
2. iterates over each serialized entry to determine if we should save the cookies for that host
2a. uses a regex to determine if it's https?: vs file:
2b. if https?:, then creates nsIURI to figure out if it's http or https (WHHHHYYY)
I need to look closer to see what exactly the regex is doing with user:foo@domain.com, but we can grab those bits too.
Using uri.schemeIs("https") is apparently an optimization, but if it means creating a ton of uris, then it doesn't really seem like anything is being optimized.
Attachment #599096 -
Flags: review?(neil)
Comment 1•13 years ago
|
||
Comment on attachment 599096 [details] [diff] [review]
patch
>+ try {
>+ entry._host = aEntry.URI.host;
>+ entry._scheme = aEntry.URI.scheme;
Please set the scheme first. r=me with that fixed.
>+ // _host and _scheme may not be set (for about: urls for example), in which
>+ // case testing _scheme will be sufficient.
Note that all URIs have a scheme, so it will now be set, and the host will be set for at least those schemes that we are interested in (https?|file).
Attachment #599096 -
Flags: review?(neil) → review+
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #1)
> >+ // _host and _scheme may not be set (for about: urls for example), in which
> >+ // case testing _scheme will be sufficient.
> Note that all URIs have a scheme, so it will now be set, and the host will
> be set for at least those schemes that we are interested in (https?|file).
You mean it's safe to throw away check for !aHosts[aEntry._host] ?
Assignee | ||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•