Closed
Bug 729123
Opened 12 years ago
Closed 12 years ago
New image for focal.ie search plugin
Categories
(Mozilla Localizations :: ga-IE / Irish, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kscanne, Assigned: kscanne)
Details
(Keywords: productization)
Attachments
(1 file, 2 obsolete files)
2.45 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
I received a request from Fiontar at Dublin City University, the organization that runs focal.ie, to update the icon used with their search plugin. Attaching a patch that does this on aurora for mail, mobile, and browser.
Assignee | ||
Updated•12 years ago
|
Keywords: productization
Updated•12 years ago
|
Attachment #599180 -
Attachment is patch: true
Comment 1•12 years ago
|
||
Comment on attachment 599180 [details] [diff] [review] focal.xml patch The browser and mail ones look good, the mobile one does not. That's actually already the current icon, but in a higher resolution, and I think we should probably keep that.
Attachment #599180 -
Flags: review-
Assignee | ||
Comment 2•12 years ago
|
||
Second attempt. Copied the high resolution mobile image to browser and mail.
Attachment #599180 -
Attachment is obsolete: true
Attachment #599201 -
Flags: review?(l10n)
Comment 3•12 years ago
|
||
Comment on attachment 599201 [details] [diff] [review] High-res image for mail/browser Review of attachment 599201 [details] [diff] [review]: ----------------------------------------------------------------- r-, sorry, probably said that wrong. For desktop and mail, we should continue to use small icons, and update to the new icon. For mobile, we continue to use the bigger icon.
Attachment #599201 -
Flags: review?(l10n) → review-
Assignee | ||
Comment 4•12 years ago
|
||
Third time's the charm hopefully, sorry about that.
Attachment #599201 -
Attachment is obsolete: true
Attachment #600670 -
Flags: review?(l10n)
Comment 5•12 years ago
|
||
Comment on attachment 600670 [details] [diff] [review] New icon, desktop and mail only this time Review of attachment 600670 [details] [diff] [review]: ----------------------------------------------------------------- Yep, thanks. Sorry for the lag in the last review cycle here. As usual, please land this with a check-in comment referencing this bug and the review, something like "bug 729123, update icons for focal.ie, r=Pike" would work.
Attachment #600670 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Thanks. Landed: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/69abbc9527e3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•