729139 - Sign not dropped from negative arc radiis

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cork]

Attachment: testcase

According to the spec for out-of-range parameters[1] negative radiis should drop there sign. Firefox doesn't do this and instead drops the arc.

In the attached testcase the left arc should look the same as the right.

[1] http://www.w3.org/TR/SVG11/implnote.html#ArcImplementationNotes

Comment 1

[Robert Longson [:longsonr]]

While the implementation notes state that negative radius values should be handled (ie, set by the DOM), the BNF for path data states that only non-negative numbers are allowed in the attribute:

http://www.w3.org/TR/SVG/paths.html#PathDataBNF

Comment 2

[Cameron McCormack (:heycam)]

IE, Chrome, Safari and Opera all seem to accept the negative radius in the path data.  I think we should accept it too and amend the spec.

Comment 3

[Jonathan Watt [:jwatt]]

Yeah, I think that's what we should do.

Comment 4

[Cameron McCormack (:heycam)]

Filed https://www.w3.org/Graphics/SVG/WG/track/issues/2439.

Comment 5

[Cork]

Any update on this?

As far as I can tell there's no response to the w3 issue.

Comment 6

[Cameron McCormack (:heycam)]

It's clearly the right thing to do, so I just made the change in the spec: https://svgwg.org/svg2-draft/paths.html#PathDataBNF

Comment 7

[Robert Longson [:longsonr]]

Attachment: patch

Comment 8

[Robert Longson [:longsonr]]

Attachment: remove unused code too.

Just noticed that arcs were the only user of ParseNonNegativeNumber so the method itself can go.

Comment 9

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=8c668156b4aa

Comment 10

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da4714c5e564

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da4714c5e564