Closed Bug 729212 Opened 8 years ago Closed 8 years ago

Port |Bug 717225 - Figure out why folderTree.json is getting corrupted, and improve stability during writing| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

defect

Tracking

(seamonkey2.9 fixed)

RESOLVED FIXED
seamonkey2.10
Tracking Status
seamonkey2.9 --- fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

(Keywords: dataloss)

Attachments

(1 file)

No description provided.
Ping for review.
Comment on attachment 599268 [details] [diff] [review]
(Av1) abTrees.js: Use a safe-file-output-stream
[Checked in: See comments 4 and 5]

>+      let foStream = Components.classes["@mozilla.org/network/safe-file-output-stream;1"]
>                                .createInstance(Components.interfaces.nsIFileOutputStream);
>-
>       foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0);
>       foStream.write(data, data.length);
>+      foStream.QueryInterface(Ci.nsISafeOutputStream).finish();

You need to replace the Ci with Components.interfaces here as well.

r/moa=me with that.

Sorry for the long delay.
Attachment #599268 - Flags: superreview+
Attachment #599268 - Flags: review?(mnyromyr)
Attachment #599268 - Flags: review+
Comment on attachment 599268 [details] [diff] [review]
(Av1) abTrees.js: Use a safe-file-output-stream
[Checked in: See comments 4 and 5]

http://hg.mozilla.org/comm-central/rev/329a4f21d574
Attachment #599268 - Attachment description: (Av1) abTrees.js: Use a safe-file-output-stream → (Av1) abTrees.js: Use a safe-file-output-stream [Checked in: Comment 4]
Attachment #599268 - Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #599268 - Attachment description: (Av1) abTrees.js: Use a safe-file-output-stream [Checked in: Comment 4] → (Av1) abTrees.js: Use a safe-file-output-stream [Checked in: See comment 4]
Attachment #599268 - Flags: approval-comm-aurora? → approval-comm-aurora+
Keywords: checkin-needed
Whiteboard: [c-n: 329a4f21d574 to c-a]
Comment on attachment 599268 [details] [diff] [review]
(Av1) abTrees.js: Use a safe-file-output-stream
[Checked in: See comments 4 and 5]

http://hg.mozilla.org/releases/comm-aurora/rev/7b7fa546c0c3
Attachment #599268 - Attachment description: (Av1) abTrees.js: Use a safe-file-output-stream [Checked in: See comment 4] → (Av1) abTrees.js: Use a safe-file-output-stream [Checked in: See comments 4 and 5]
Keywords: checkin-needed
Whiteboard: [c-n: 329a4f21d574 to c-a]
You need to log in before you can comment on or make changes to this bug.