Closed Bug 729241 Opened 11 years ago Closed 10 months ago

switch-to-tab selections should update adaptive matching records

Categories

(Firefox :: Address Bar, defect, P3)

defect
Points:
5

Tracking

()

VERIFIED FIXED
97 Branch
Tracking Status
firefox97 --- verified

People

(Reporter: dietrich, Assigned: mcheang, Mentored)

References

Details

(Whiteboard: [switch-to-tab])

Attachments

(1 file, 1 obsolete file)

URLs A, B and C are in history, with frecency/adaptivity making C the 3rd item in the awesomebar when matching all three.

Select C's switch to tab entry (the 3rd one down, remember). Now do that 1 million times.

URL C is still the 3rd one down in the awesomebar.

It should be higher, reflecting my constant search-to-navigate action.
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [switch-to-tab]
Blocks: 610720
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Priority: -- → P3
Resolution: INACTIVE → ---
Points: --- → 5

We have a UrlbarUtils.addToInputHistory method that could probably be invoked for switch to tab results here https://searchfox.org/mozilla-central/rev/50c3cf7a3c931409b54efa009795b69c19383541/browser/components/urlbar/UrlbarInput.jsm#842
Then a test should be added using https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_inputHistory.js as inspiration

Mentor: mak
Assignee: nobody → mcheang

This is going to be awesome. Thanks for working on this.

Pushed by mcheang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/359a3b16c34b
Switch-to-tab selections update adaptive records. r=harry,mak
Attachment #9253511 - Attachment is obsolete: true
Status: REOPENED → RESOLVED
Closed: 4 years ago10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

The issue is verified fixed on the latest Fx98.0a1 on Windows 10 and Ubuntu 20.04. After clicking the switch to tab button on the third entry, the frecency is increased, so in a new tab it is listed as the first entry in the suggest section.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.