Closed Bug 729261 Opened 10 years ago Closed 10 years ago

PB transition sets the usePrivateBrowsing attribute too eagerly

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 13

People

(Reporter: jdm, Assigned: jdm)

References

Details

Attachments

(1 file)

Set private browsing attribute on windows that exist after transition into PB mode.
3.01 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
We end up setting the attribute for all windows that exist before transitioning, rather than all windows that exist after the transition. This is unfortunate.
Attachment #599314 - Flags: review?(ehsan)
Blocks: PBnGen
Comment on attachment 599314 [details] [diff] [review]
Set private browsing attribute on windows that exist after transition into PB mode.

Review of attachment 599314 [details] [diff] [review]:
-----------------------------------------------------------------

Hehe, nice!
Attachment #599314 - Flags: review?(ehsan) → review+
Whiteboard: [needs landing]
Whiteboard: [needs landing]
https://hg.mozilla.org/mozilla-central/rev/15461fddfe45
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.