PB transition sets the usePrivateBrowsing attribute too eagerly

RESOLVED FIXED in Firefox 13

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
Firefox 13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
We end up setting the attribute for all windows that exist before transitioning, rather than all windows that exist after the transition. This is unfortunate.
(Assignee)

Comment 1

7 years ago
Created attachment 599314 [details] [diff] [review]
Set private browsing attribute on windows that exist after transition into PB mode.

Mea culpa.
(Assignee)

Updated

7 years ago
Attachment #599314 - Flags: review?(ehsan)
(Assignee)

Updated

7 years ago
Blocks: 463027

Comment 2

7 years ago
Comment on attachment 599314 [details] [diff] [review]
Set private browsing attribute on windows that exist after transition into PB mode.

Review of attachment 599314 [details] [diff] [review]:
-----------------------------------------------------------------

Hehe, nice!
Attachment #599314 - Flags: review?(ehsan) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [needs landing]
(Assignee)

Updated

7 years ago
Whiteboard: [needs landing]
https://hg.mozilla.org/mozilla-central/rev/15461fddfe45
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.