PB transition sets the usePrivateBrowsing attribute too eagerly

RESOLVED FIXED in Firefox 13

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
Firefox 13
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We end up setting the attribute for all windows that exist before transitioning, rather than all windows that exist after the transition. This is unfortunate.
Attachment #599314 - Flags: review?(ehsan)
Blocks: PBnGen
Comment on attachment 599314 [details] [diff] [review]
Set private browsing attribute on windows that exist after transition into PB mode.

Review of attachment 599314 [details] [diff] [review]:
-----------------------------------------------------------------

Hehe, nice!
Attachment #599314 - Flags: review?(ehsan) → review+
Whiteboard: [needs landing]
Whiteboard: [needs landing]
https://hg.mozilla.org/mozilla-central/rev/15461fddfe45
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.