729324 - Always make sure 'Quit' is last menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Add-ons can add menu items and those menu items are appended to the end of the menu. For consistency and better UX, we should always make sure 'Quit' is the last menu item.

This patch uses the orderInCategory attribute to put 'Quit' in a higher order. All other menus use an order of None, so 'Quit' is always at the end. Tested with a few add-ons.

Madhava was OK with this change when we spoke on IRC

Comment 1

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 599373 [details] [diff] [review]
patch

This looks good to me. I am not sure if this attribute is available since Eclair. The documentation doesn't have the API levels for XML attributes. So we might have to have a watch on this.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

it looks like orderInCategory is in the eclair source, so I hope it works:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f579a1ad62

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a1f579a1ad62

Comment 4

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-24)
20120224031039
http://hg.mozilla.org/mozilla-central/rev/cd120efbe4c6

--
Device: Motorola Droid 2
OS: Android 2.3.3