Closed Bug 729324 Opened 9 years ago Closed 9 years ago

Always make sure 'Quit' is last menu

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 13

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Add-ons can add menu items and those menu items are appended to the end of the menu. For consistency and better UX, we should always make sure 'Quit' is the last menu item.

This patch uses the orderInCategory attribute to put 'Quit' in a higher order. All other menus use an order of None, so 'Quit' is always at the end. Tested with a few add-ons.

Madhava was OK with this change when we spoke on IRC
Attachment #599373 - Flags: review?(sriram)
Comment on attachment 599373 [details] [diff] [review]
patch

This looks good to me. I am not sure if this attribute is available since Eclair. The documentation doesn't have the API levels for XML attributes. So we might have to have a watch on this.
Attachment #599373 - Flags: review?(sriram) → review+
it looks like orderInCategory is in the eclair source, so I hope it works:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f579a1ad62
https://hg.mozilla.org/mozilla-central/rev/a1f579a1ad62
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Verified fixed on:

Firefox 13.0a1 (2012-02-24)
20120224031039
http://hg.mozilla.org/mozilla-central/rev/cd120efbe4c6

--
Device: Motorola Droid 2
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.