Incremental GC should mark filenames of newly allocated scripts

RESOLVED FIXED in Firefox 13

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(firefox13+ fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
See bug #641025 comment 124:
tracking-firefox13: --- → +
We also need to mark whenever we look up a filename in the hashtable, since it's effectively a weak pointer.
(Assignee)

Comment 2

5 years ago
(In reply to Bill McCloskey (:billm) from comment #1)
> We also need to mark whenever we look up a filename in the hashtable, since
> it's effectively a weak pointer.

My plan is to mark newly incremental filename entries under the incremental GC. The rest of cases should be covered by normal marking as the filename is never overwritten. But eventually I want to either remove them or at least turn them into atoms. My initial measurements shows that filename strings are atoms in about 10-15% cases so turning mostly ascii string into UTF16 char array + JSString header should not bloat memory match...
(Assignee)

Comment 3

5 years ago
Created attachment 600089 [details] [diff] [review]
v1
Attachment #600089 - Flags: review?(wmccloskey)
Comment on attachment 600089 [details] [diff] [review]
v1

Thanks.
Attachment #600089 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b449b1eea2
https://hg.mozilla.org/mozilla-central/rev/f3b449b1eea2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13

Updated

5 years ago
status-firefox13: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.