GetGLFrameBufferFormat need to be specified for maemo in Qt port

RESOLVED FIXED in mozilla13

Status

RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

unspecified
mozilla13
ARM
Maemo

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
recent trunk crashes fennec on N9 due to missing local FB format definition
we should add it similar to gonk port
(Assignee)

Comment 1

7 years ago
Created attachment 599519 [details] [diff] [review]
nsWindow::GetGLFrameBufferFormat return RGB for maemo
Assignee: nobody → romaxa
Attachment #599519 - Flags: review?(ajuma)

Comment 2

7 years ago
Comment on attachment 599519 [details] [diff] [review]
nsWindow::GetGLFrameBufferFormat return RGB for maemo

Review of attachment 599519 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/qt/nsWindow.cpp
@@ +3311,5 @@
> +nsWindow::GetGLFrameBufferFormat()
> +{
> +    if (mLayerManager &&
> +        mLayerManager->GetBackendType() == LayerManager::LAYERS_OPENGL) {
> +        // We directly map the hardware fb on Gonk.  The hardware fb

Please update this comment (we're not in Gonk here).
Attachment #599519 - Flags: review?(ajuma) → review+

Comment 3

7 years ago
https://hg.mozilla.org/mozilla-central/rev/54fea02135ab
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.