729550 - Port |Bug 728071 - application.ini data should be in libmozglue.so, not libxul.so| to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Serge Gautherie (:sgautherie)]

http://build.mozillamessaging.com/tinderboxpushlog/?tree=SeaMonkey&rev=458e96a21f60

"comm-central/458e96a21f60, mozilla-central/373c710112e6": green.

"comm-central/458e96a21f60, mozilla-central/e722d2ab78da": red.
{
nsSuiteApp.cpp
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o nsSuiteApp.o [...]
In file included from /builds/slave/comm-cen-trunk-lnx64/build/suite/app/nsSuiteApp.cpp:39:0:
../../mozilla/build/application.ini.h:4:18: error: ‘NULL’ was not declared in this scope
../../mozilla/build/application.ini.h:10:18: error: ‘NULL’ was not declared in this scope
../../mozilla/build/application.ini.h:12:18: error: ‘NULL’ was not declared in this scope
In file included from /builds/slave/comm-cen-trunk-lnx64/build/suite/app/nsSuiteApp.cpp:39:0:
../../mozilla/build/application.ini.h:16:18: error: ‘NULL’ was not declared in this scope
/builds/slave/comm-cen-trunk-lnx64/build/suite/app/nsSuiteApp.cpp:123:1: error: ‘XRE_GetFileFromPathType’ does not name a type
[ and more ]
}

Comment 1

[Ed Morley [:emorley]]

Bug 728071 perhaps?

Comment 2

[Serge Gautherie (:sgautherie)]

["Mid-air collision detected!". Anyway:]

At first glance, I noticed bug 728071
https://hg.mozilla.org/mozilla-central/rev/0e2ee581bf93

It seems we need to port that...

Comment 3

[Mike Hommey [:glandium]]

yes, you need that: https://hg.mozilla.org/mozilla-central/diff/0e2ee581bf93/b2g/app/nsBrowserApp.cpp
Thunderbird is not affected afaics.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) nsSuiteApp.cpp: Include "nsXULAppAPI.h"

For post-push review of
http://hg.mozilla.org/comm-central/rev/a586613f71ee

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Mike Hommey [:glandium] from comment #3)

> yes, you need that:
> https://hg.mozilla.org/mozilla-central/diff/0e2ee581bf93/b2g/app/
> nsBrowserApp.cpp

Thanks for the confirmation.

Ftr, would love to know about changes like this before they hit m-c...

> Thunderbird is not affected afaics.

Yes, I had checked that. Probably because they don't use "application.ini.h" (yet).

Comment 6

[Mike Hommey [:glandium]]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> Thanks for the confirmation.
> 
> Ftr, would love to know about changes like this before they hit m-c...

I usually do. But I thought c-c wasn't using application.ini.h yet. I was only half right. (and yes, I reviewed 722262, but that got off my mind)

Comment 7

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1329928386.1329930445.7780.gz
Linux x86-64 comm-central-trunk build on 2012/02/22 08:33:06

V.Fixed