Closed
Bug 729596
Opened 12 years ago
Closed 12 years ago
mozglue/linker/szip.cpp compile error on Mac: ‘posix_fallocate’ was not declared
Categories
(Core :: mozglue, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: cpeterson, Assigned: glandium)
References
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
Compiling m-c on Mac gives the following compile error: /mozilla/inbound3/mozglue/linker/szip.cpp: In function ‘int main(int, char**)’: /mozilla/inbound3/mozglue/linker/szip.cpp:70: error: ‘posix_fallocate’ was not declared in this scope glandium's workaround patch: http://pastebin.mozilla.org/1490507
|
Reporter | |
Updated•12 years ago
|
Summary: mozglue compile error on Mac: linker/szip.cpp: ‘posix_fallocate’ was not declared mozglue compile error on Mac: linker/szip.cpp: ‘posix_fallocate’ was not declared → mozglue/linker/szip.cpp compile error on Mac: ‘posix_fallocate’ was not declared mozglue/linker/szip.cpp compile error on Mac: ‘posix_fallocate’ was not declared
|
Assignee | |
Updated•12 years ago
|
Component: General → mozglue
Product: Firefox → Core
QA Contact: general → mozglue
|
|
Assignee | |
Comment 1•12 years ago
|
||
We could use the equivalent of posix_fallocate for mac, but since the file is filled sequentially anyways, and since it's a host program, it's not worth bothering.
Attachment #599693 -
Flags: review?(taras.mozilla)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 599693 [details] [diff] [review] Use ftruncate in szip instead of posix_fallocate I don't think I need to review trivial changes like this.
Attachment #599693 -
Flags: review?(taras.mozilla) → review+
|
||
Comment 4•12 years ago
|
||
Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/775aeed72aef Someone should probably land this directly on m-c.
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/775aeed72aef
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•