Near-duplicate code in LayerManagerOGL::CopyToTarget() as GLContext::ReadPixelsIntoImageSurface()

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
It seems that CopyToTarget should just use ReadPixelsIntoImageSurface instead of replicating the functionality itself.
(Assignee)

Comment 1

6 years ago
Created attachment 599786 [details] [diff] [review]
Use function instead of duplicating functionality.

Also folds an optimization into the main readback function.
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
Attachment #599786 - Flags: review?

Updated

6 years ago
Attachment #599786 - Flags: review? → review+
(Assignee)

Comment 2

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=c5aec89adec3
Whiteboard: [rplus]
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/64086bfc8849
Whiteboard: [rplus]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/64086bfc8849
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Assignee: jgilbert → nobody
(Assignee)

Updated

6 years ago
Assignee: nobody → jgilbert
You need to log in before you can comment on or make changes to this bug.