Last Comment Bug 729702 - Near-duplicate code in LayerManagerOGL::CopyToTarget() as GLContext::ReadPixelsIntoImageSurface()
: Near-duplicate code in LayerManagerOGL::CopyToTarget() as GLContext::ReadPixe...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: Jeff Gilbert [:jgilbert]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-22 13:56 PST by Jeff Gilbert [:jgilbert]
Modified: 2012-03-21 13:56 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use function instead of duplicating functionality. (3.49 KB, patch)
2012-02-22 15:03 PST, Jeff Gilbert [:jgilbert]
bgirard: review+
Details | Diff | Review

Description Jeff Gilbert [:jgilbert] 2012-02-22 13:56:40 PST
It seems that CopyToTarget should just use ReadPixelsIntoImageSurface instead of replicating the functionality itself.
Comment 1 Jeff Gilbert [:jgilbert] 2012-02-22 15:03:03 PST
Created attachment 599786 [details] [diff] [review]
Use function instead of duplicating functionality.

Also folds an optimization into the main readback function.
Comment 2 Jeff Gilbert [:jgilbert] 2012-03-12 16:17:28 PDT
https://tbpl.mozilla.org/?tree=Try&rev=c5aec89adec3
Comment 4 Marco Bonardo [::mak] 2012-03-13 05:54:57 PDT
https://hg.mozilla.org/mozilla-central/rev/64086bfc8849

Note You need to log in before you can comment on or make changes to this bug.