729706 - Ensure worker XHRs inherit load context of page in private mode

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Josh Matthews [:jdm]]

This came up in the security review and should be investigated.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pretty sure we do this correctly already, sicking should verify:

https://mxr.mozilla.org/mozilla-central/source/dom/workers/XMLHttpRequestPrivate.cpp#125

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Josh, can you clarify what constitutes "load context" here? Loads happening from worker-xhr as well as importScripts inside workers (importScripts allows dynamic loading of script files).

Before starting any loads, we check the load against the principal of the page.

Every load is also added to the page's LoadGroup.

Is anything else needed?

Comment 3

[Josh Matthews [:jdm]]

In this case, we care that the nsILoadContext of the channel is the same as the one you would get from a non-worker XHR.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

How does one get from a nsIChannel to a nsILoadContext? I've never heard of associating nsILoadContext directly with nsIChannels at all.

Comment 5

[Josh Matthews [:jdm]]

NS_QueryNotificationCallbacks on an nsIChannel gets you an nsILoadContext.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

That goes through the loadgroup, so yeah, that should be fine

Comment 7

[Josh Matthews [:jdm]]

Thanks!